mirror of
https://github.com/docker/compose.git
synced 2026-09-22 05:24:22 +00:00
fc860cbd1f
`up --abort-on-container-exit` tore down the project when a one-off container created by `docker compose run` exited. The container list built in monitor.Start already excludes one-off containers via oneOffFilter(false), but the event subscription did not, and the only guard on incoming events is the service label, which a one-off container inherits from the service it was run from. Regression since v2.39.0 (last unaffected release is v2.38.2), and a recurrence of docker/compose-cli#1955, fixed there by docker/compose-cli#1987. Signed-off-by: Branislav Osif <brano@osif.digital>
84 lines
2.7 KiB
Go
84 lines
2.7 KiB
Go
//go:build !windows
|
|
|
|
/*
|
|
Copyright 2022 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package e2e
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"gotest.tools/v3/assert"
|
|
"gotest.tools/v3/icmd"
|
|
"gotest.tools/v3/poll"
|
|
)
|
|
|
|
func TestCascadeStop(t *testing.T) {
|
|
c := NewCLI(t)
|
|
const projectName = "compose-e2e-cascade-stop"
|
|
t.Cleanup(func() {
|
|
c.RunDockerComposeCmd(t, "--project-name", projectName, "down")
|
|
})
|
|
|
|
res := c.RunDockerComposeCmd(t, "-f", "./fixtures/cascade/compose.yaml", "--project-name", projectName,
|
|
"up", "--abort-on-container-exit")
|
|
assert.Assert(t, strings.Contains(res.Combined(), "exit-1 exited with code 0"), res.Combined())
|
|
// no --exit-code-from, so this is not an error
|
|
assert.Equal(t, res.ExitCode, 0)
|
|
}
|
|
|
|
func TestCascadeIgnoresOneOffContainer(t *testing.T) {
|
|
const projectName = "compose-e2e-cascade-oneoff"
|
|
c := NewCLI(t, WithEnv("COMPOSE_PROJECT_NAME="+projectName))
|
|
t.Cleanup(func() {
|
|
c.RunDockerComposeCmd(t, "down")
|
|
})
|
|
|
|
cmd := c.NewDockerComposeCmd(t, "-f", "./fixtures/cascade/compose.yaml",
|
|
"up", "--abort-on-container-exit", "--menu=false", "running")
|
|
res := icmd.StartCmd(cmd)
|
|
t.Cleanup(func() {
|
|
_ = res.Cmd.Process.Kill()
|
|
})
|
|
|
|
poll.WaitOn(t, expectOutput(res, "Attaching to running-1"),
|
|
poll.WithDelay(100*time.Millisecond), poll.WithTimeout(30*time.Second))
|
|
|
|
c.RunDockerComposeCmd(t, "-f", "./fixtures/cascade/compose.yaml",
|
|
"run", "--rm", "--no-deps", "running", "/bin/true")
|
|
|
|
time.Sleep(3 * time.Second)
|
|
|
|
assert.Assert(t, !strings.Contains(res.Combined(), "Aborting on container exit"), res.Combined())
|
|
RequireServiceState(t, c, "running", "running")
|
|
}
|
|
|
|
func TestCascadeFail(t *testing.T) {
|
|
c := NewCLI(t)
|
|
const projectName = "compose-e2e-cascade-fail"
|
|
t.Cleanup(func() {
|
|
c.RunDockerComposeCmd(t, "--project-name", projectName, "down")
|
|
})
|
|
|
|
res := c.RunDockerComposeCmdNoCheck(t, "-f", "./fixtures/cascade/compose.yaml", "--project-name", projectName,
|
|
"up", "--abort-on-container-failure")
|
|
assert.Assert(t, strings.Contains(res.Combined(), "exit-1 exited with code 0"), res.Combined())
|
|
assert.Assert(t, strings.Contains(res.Combined(), "fail-1 exited with code 111"), res.Combined())
|
|
// failing exit code should be propagated
|
|
assert.Equal(t, res.ExitCode, 111)
|
|
}
|