* s/AccessKeyDataLimit/DefaultDataLimit/g for shadowbox
* Implement per-key custom data limits in shadowbox
* Shadowbox integration test
* Fix the manager service test to maintain backwards compatibility with
the GET /server response
* Fix integration test for Travis
* Fix lint errors
* Implement removal of access key data limits
* Persist custom data limits
* Bump Shadowbox version number
* Add a per key dat alimit count to the feature metrics endpoint
This also involved modifying the schema of
uproxysite:uproxy_metrics_dev.feature_metrics to include the new field.
See https://cloud.google.com/bigquery/docs/managing-table-schemas#bq_1
for how this was accomplished
Tested:
yarn do metrics_server/test && yarn do metrics_server/test_integration
* Collect usage metrics for per-key data limits
* API documentation and cleanup
* Respond to review comments
* Respond to review comments
* Don't encode the data limit in the access key url
This should have been caught in the integration test, but the
integration test was miswritten with "echo" instead of "fail", cause the
test to mistakenly pass.
Fixing this exposed other errors in the test, which were fixed. The
test has been confirmed to both pass and fail successfully.
* Fix the manager service unit test
* Remove stray files
* Split integration test into individual functions
* Clarify comment in the AccessKey interface
* Be more explicit about behavior when no data limits are set
* Remove spuriosu import added by vscode
* DOn't bump shadowbox version number yet
* Rename to accessKeyToApiJson
* Don't export AccessKeyJson and use "StorageJson"
* Don't await data limit enforcement
* Rename the defaultDataLimit getter
* Make dataLimit in the accesskey model readonly
* Use nullish coalescing operator
* Create an endpoint to change the server's hostname.
This is the backend only, and does not check if the hostname exists or points to a Shadowbox
server. Users have the responsibility of double checking that the
hostname and DNS if necessary are properly set up and specified.
* Updates
Changes validation to use regex.
Gets rid of a bad test
Uses paramtereized tests for better test output
Adds setHostname to AccessKeyRepository and calls it in the endpoint
* Integration tests
Also fixes missing dependency on ip-regex
* Remove validator from lockfile
* Ensure we correctly use Python 2 for Cloud SDK
* API for the new endpoint to change the server hostname. (#534)
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* Remove 404 and 406 error states. Checking for a functioning Shadowbox
server requires knowledge of the API prefix, which creates layering
challenges. The UI will be able to make these checks, but users who
call the API directly will have to be careful not to put in an incorrect
hostname. The consequence of this would be that newly made access keys
won't work.
* Clarify API, change name, add validation errors
* Clarify description
* Remove the API response corresponding to a failed check against the new
hostname that it points to the same server
* Respond to review comments
* Rename endpoint and related functions
From the server's perspective, this does change the hostname for
existing access keys since on server load time (in the Server Manager)
we recalculate access key hostnames from the key repository.
* Respond to review comments
* Use version 1.2.0 since data limits is taking 1.1.0
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* UI for setting the hostname for access key invitations (#553)
* Increase Shadowbox version for data limits experiment (#544)
* Return the port for new access keys from GET /server. (#552)
This was accidentally removed in #537.
* UI for setting the hostname for access key invitations
This also includes some random typo fixes and QOL improvements.
To test, you can use
export SB_IMAGE=cohenjongoogle/shadowbox:latest
yarn do shadowbox/docker/run
then in a different terminal
yarn do server_manager/electron_app/run
and add the server
* Add back in new files
Also fixes a backward compatibility issues for servers which don't
support changing the hostname
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Use DB-IP's Geolocation database instead of MaxMind's (#557)
* Use DB-IP's free IP-to-Country database instead of MaxMind's
This avoids the necesseity to either (1) bundle MaxMind's database in
our docker image or (2) require server admins to individually create
MaxMind accounts due to the new requirements for using GeoLite2
databases. See https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
* Add attribution to DB-IP for the GeoIP database
* Make sure that we deal with lag between the changeover of the current
month and release of new versions of the DB-IP database
* Respond to review comments
* Attribute DB-IP in the update script
* Respond to review comments
* Respond to review comments
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* Update to Typescript 3.7 (#558)
See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html for more information. Among the nice new features are optional chainging and null coalescing, and assertion functions, as well as some additional safety checks in the compiler
* Create an endpoint to change the server's hostname.
This is the backend only, and does not check if the hostname exists or points to a Shadowbox
server. Users have the responsibility of double checking that the
hostname and DNS if necessary are properly set up and specified.
* Updates
Changes validation to use regex.
Gets rid of a bad test
Uses paramtereized tests for better test output
Adds setHostname to AccessKeyRepository and calls it in the endpoint
* Integration tests
Also fixes missing dependency on ip-regex
* Remove validator from lockfile
* Ensure we correctly use Python 2 for Cloud SDK
* API for the new endpoint to change the server hostname. (#534)
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* Remove 404 and 406 error states. Checking for a functioning Shadowbox
server requires knowledge of the API prefix, which creates layering
challenges. The UI will be able to make these checks, but users who
call the API directly will have to be careful not to put in an incorrect
hostname. The consequence of this would be that newly made access keys
won't work.
* Clarify API, change name, add validation errors
* Clarify description
* Remove the API response corresponding to a failed check against the new
hostname that it points to the same server
* Respond to review comments
* Rename endpoint and related functions
From the server's perspective, this does change the hostname for
existing access keys since on server load time (in the Server Manager)
we recalculate access key hostnames from the key repository.
* Respond to review comments
* Use version 1.2.0 since data limits is taking 1.1.0
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* UI for setting the hostname for access key invitations
This also includes some random typo fixes and QOL improvements.
To test, you can use
export SB_IMAGE=cohenjongoogle/shadowbox:latest
yarn do shadowbox/docker/run
then in a different terminal
yarn do server_manager/electron_app/run
and add the server
* Add back in new files
Also fixes a backward compatibility issues for servers which don't
support changing the hostname
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Fix messed up rebase
* merge
* Clear merge markers
Co-authored-by: alalamav <2132122+alalamav@users.noreply.github.com>
* Create an endpoint to change the server's hostname.
This is the backend only, and does not check if the hostname exists or points to a Shadowbox
server. Users have the responsibility of double checking that the
hostname and DNS if necessary are properly set up and specified.
* Updates
Changes validation to use regex.
Gets rid of a bad test
Uses paramtereized tests for better test output
Adds setHostname to AccessKeyRepository and calls it in the endpoint
* Integration tests
Also fixes missing dependency on ip-regex
* Remove validator from lockfile
* Ensure we correctly use Python 2 for Cloud SDK
* API for the new endpoint to change the server hostname. (#534)
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* Remove 404 and 406 error states. Checking for a functioning Shadowbox
server requires knowledge of the API prefix, which creates layering
challenges. The UI will be able to make these checks, but users who
call the API directly will have to be careful not to put in an incorrect
hostname. The consequence of this would be that newly made access keys
won't work.
* Clarify API, change name, add validation errors
* Clarify description
* Remove the API response corresponding to a failed check against the new
hostname that it points to the same server
* Respond to review comments
* Rename endpoint and related functions
From the server's perspective, this does change the hostname for
existing access keys since on server load time (in the Server Manager)
we recalculate access key hostnames from the key repository.
* Respond to review comments
* Use version 1.2.0 since data limits is taking 1.1.0
* UI for setting the hostname for access key invitations (#553)
* Increase Shadowbox version for data limits experiment (#544)
* Return the port for new access keys from GET /server. (#552)
This was accidentally removed in #537.
* UI for setting the hostname for access key invitations
This also includes some random typo fixes and QOL improvements.
To test, you can use
export SB_IMAGE=cohenjongoogle/shadowbox:latest
yarn do shadowbox/docker/run
then in a different terminal
yarn do server_manager/electron_app/run
and add the server
* Add back in new files
Also fixes a backward compatibility issues for servers which don't
support changing the hostname
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Use DB-IP's Geolocation database instead of MaxMind's (#557)
* Use DB-IP's free IP-to-Country database instead of MaxMind's
This avoids the necesseity to either (1) bundle MaxMind's database in
our docker image or (2) require server admins to individually create
MaxMind accounts due to the new requirements for using GeoLite2
databases. See https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
* Add attribution to DB-IP for the GeoIP database
* Make sure that we deal with lag between the changeover of the current
month and release of new versions of the DB-IP database
* Respond to review comments
* Attribute DB-IP in the update script
* Respond to review comments
* Respond to review comments
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* Update to Typescript 3.7 (#558)
See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html for more information. Among the nice new features are optional chainging and null coalescing, and assertion functions, as well as some additional safety checks in the compiler
* Create an endpoint to change the server's hostname.
This is the backend only, and does not check if the hostname exists or points to a Shadowbox
server. Users have the responsibility of double checking that the
hostname and DNS if necessary are properly set up and specified.
* Updates
Changes validation to use regex.
Gets rid of a bad test
Uses paramtereized tests for better test output
Adds setHostname to AccessKeyRepository and calls it in the endpoint
* Integration tests
Also fixes missing dependency on ip-regex
* Remove validator from lockfile
* Ensure we correctly use Python 2 for Cloud SDK
* API for the new endpoint to change the server hostname. (#534)
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* Remove 404 and 406 error states. Checking for a functioning Shadowbox
server requires knowledge of the API prefix, which creates layering
challenges. The UI will be able to make these checks, but users who
call the API directly will have to be careful not to put in an incorrect
hostname. The consequence of this would be that newly made access keys
won't work.
* Clarify API, change name, add validation errors
* Clarify description
* Remove the API response corresponding to a failed check against the new
hostname that it points to the same server
* Respond to review comments
* Rename endpoint and related functions
From the server's perspective, this does change the hostname for
existing access keys since on server load time (in the Server Manager)
we recalculate access key hostnames from the key repository.
* Respond to review comments
* Use version 1.2.0 since data limits is taking 1.1.0
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* UI for setting the hostname for access key invitations
This also includes some random typo fixes and QOL improvements.
To test, you can use
export SB_IMAGE=cohenjongoogle/shadowbox:latest
yarn do shadowbox/docker/run
then in a different terminal
yarn do server_manager/electron_app/run
and add the server
* Add back in new files
Also fixes a backward compatibility issues for servers which don't
support changing the hostname
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Fix messed up rebase
* merge
* Clear merge markers
Co-authored-by: alalamav <2132122+alalamav@users.noreply.github.com>
Co-authored-by: alalamav <2132122+alalamav@users.noreply.github.com>
* Get public hostname from config file
* Tidy up
* Respond to Review Comments
At some point down the line I royally screwed up my git history and
reverted a bunch of changes. I'm not sure what or when, so I `git reset --hard 1cd28e4` and tried to redo my
past responses to comments from there.
* Export SB_PUBLIC_IP in cmd.sh
* respond to review comments
* Review response
* Set -x in the integration test
The integration test has been flaking from time to time on Travis with
no obvious failures, indicating this is happening unexpectedly outside a
`fail` call. `set -x` will help us diagnose when it happens again.
* Only show logs on test failure
* Correctly continue if test.sh fails
* Only cleanup the logfile on success. The logfile should stick around on
failure for easier sharing of test results. It will eventually get
cleaned up whenever the tmp directory gets cleaned.
* Add an endpoint to set a new port for access keys
* post commit formatting
* Document the new api
* Remove enum in errors
* Respond to review comments
* Respond to review comments
* Rename to ShadowboxError and add copywright header
* Move to errors.ts
* Respond to coments in access_key.ts
* Move to errors.ts
* More renames
* post commit formatting
* More review responses
* Correctly convert invalid port number to string
* More renaming
* post commit formatting
* Respond to review comments
* Fix issue using parseInt
* Change endpoint URL
* formatting
* Respond to more review comments
* Respond to comments, add to integration test
* post commit formatting
* Move invalidPortArgument into a local
* formatting
* More review
* more review
* formatting
* disambiguate errors using restify types
* formatting
* fix the integration test
