Maintaining consistency with https://github.com/Jigsaw-Code/outline-client/pull/743 as well as with the app logos for both the client and the manager, flip all of the Outline discs so the light side is on the right. I didn't touch a few (such as metrics.png) which are more complicated and would require access to the file in whatever image editor was used to create them.
* Use Prettier to format HTML, CSS, and Markdown files
Currently alalama uses Sublime's built-in formatter while JonathanDCohen uses VS Code. This standardizes us on Prettier and adds formatting to our pre-commit hooks.
pretty-quick has no option to only format changed lines, so this commit will be followed by a format of the src/ directory in order to keep unrelated formatting changes from polluting diffs in upcoming commits.
Code contributors can use the instructions at https://prettier.io/docs/en/editors.html if they'd like to integrate prettier with their editor of choice
* Format html and css files in ui_components
* Fix some html errors found by Prettier
* Correctly internationalize new UI access key placeholder name
* Add back the keyID for non-English languages
This simply replicates the existing messages so we can release the Data
Limits UI without waiting for these strings to be translated.
* Specify that keyId will be a number
* Create an endpoint to change the server's hostname.
This is the backend only, and does not check if the hostname exists or points to a Shadowbox
server. Users have the responsibility of double checking that the
hostname and DNS if necessary are properly set up and specified.
* Updates
Changes validation to use regex.
Gets rid of a bad test
Uses paramtereized tests for better test output
Adds setHostname to AccessKeyRepository and calls it in the endpoint
* Integration tests
Also fixes missing dependency on ip-regex
* Remove validator from lockfile
* Ensure we correctly use Python 2 for Cloud SDK
* API for the new endpoint to change the server hostname. (#534)
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* Remove 404 and 406 error states. Checking for a functioning Shadowbox
server requires knowledge of the API prefix, which creates layering
challenges. The UI will be able to make these checks, but users who
call the API directly will have to be careful not to put in an incorrect
hostname. The consequence of this would be that newly made access keys
won't work.
* Clarify API, change name, add validation errors
* Clarify description
* Remove the API response corresponding to a failed check against the new
hostname that it points to the same server
* Respond to review comments
* Rename endpoint and related functions
From the server's perspective, this does change the hostname for
existing access keys since on server load time (in the Server Manager)
we recalculate access key hostnames from the key repository.
* Respond to review comments
* Use version 1.2.0 since data limits is taking 1.1.0
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* UI for setting the hostname for access key invitations (#553)
* Increase Shadowbox version for data limits experiment (#544)
* Return the port for new access keys from GET /server. (#552)
This was accidentally removed in #537.
* UI for setting the hostname for access key invitations
This also includes some random typo fixes and QOL improvements.
To test, you can use
export SB_IMAGE=cohenjongoogle/shadowbox:latest
yarn do shadowbox/docker/run
then in a different terminal
yarn do server_manager/electron_app/run
and add the server
* Add back in new files
Also fixes a backward compatibility issues for servers which don't
support changing the hostname
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Use DB-IP's Geolocation database instead of MaxMind's (#557)
* Use DB-IP's free IP-to-Country database instead of MaxMind's
This avoids the necesseity to either (1) bundle MaxMind's database in
our docker image or (2) require server admins to individually create
MaxMind accounts due to the new requirements for using GeoLite2
databases. See https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
* Add attribution to DB-IP for the GeoIP database
* Make sure that we deal with lag between the changeover of the current
month and release of new versions of the DB-IP database
* Respond to review comments
* Attribute DB-IP in the update script
* Respond to review comments
* Respond to review comments
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* Update to Typescript 3.7 (#558)
See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html for more information. Among the nice new features are optional chainging and null coalescing, and assertion functions, as well as some additional safety checks in the compiler
* Create an endpoint to change the server's hostname.
This is the backend only, and does not check if the hostname exists or points to a Shadowbox
server. Users have the responsibility of double checking that the
hostname and DNS if necessary are properly set up and specified.
* Updates
Changes validation to use regex.
Gets rid of a bad test
Uses paramtereized tests for better test output
Adds setHostname to AccessKeyRepository and calls it in the endpoint
* Integration tests
Also fixes missing dependency on ip-regex
* Remove validator from lockfile
* Ensure we correctly use Python 2 for Cloud SDK
* API for the new endpoint to change the server hostname. (#534)
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* Remove 404 and 406 error states. Checking for a functioning Shadowbox
server requires knowledge of the API prefix, which creates layering
challenges. The UI will be able to make these checks, but users who
call the API directly will have to be careful not to put in an incorrect
hostname. The consequence of this would be that newly made access keys
won't work.
* Clarify API, change name, add validation errors
* Clarify description
* Remove the API response corresponding to a failed check against the new
hostname that it points to the same server
* Respond to review comments
* Rename endpoint and related functions
From the server's perspective, this does change the hostname for
existing access keys since on server load time (in the Server Manager)
we recalculate access key hostnames from the key repository.
* Respond to review comments
* Use version 1.2.0 since data limits is taking 1.1.0
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* UI for setting the hostname for access key invitations
This also includes some random typo fixes and QOL improvements.
To test, you can use
export SB_IMAGE=cohenjongoogle/shadowbox:latest
yarn do shadowbox/docker/run
then in a different terminal
yarn do server_manager/electron_app/run
and add the server
* Add back in new files
Also fixes a backward compatibility issues for servers which don't
support changing the hostname
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Fix messed up rebase
* merge
* Clear merge markers
Co-authored-by: alalamav <2132122+alalamav@users.noreply.github.com>
* Create an endpoint to change the server's hostname.
This is the backend only, and does not check if the hostname exists or points to a Shadowbox
server. Users have the responsibility of double checking that the
hostname and DNS if necessary are properly set up and specified.
* Updates
Changes validation to use regex.
Gets rid of a bad test
Uses paramtereized tests for better test output
Adds setHostname to AccessKeyRepository and calls it in the endpoint
* Integration tests
Also fixes missing dependency on ip-regex
* Remove validator from lockfile
* Ensure we correctly use Python 2 for Cloud SDK
* API for the new endpoint to change the server hostname. (#534)
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* Remove 404 and 406 error states. Checking for a functioning Shadowbox
server requires knowledge of the API prefix, which creates layering
challenges. The UI will be able to make these checks, but users who
call the API directly will have to be careful not to put in an incorrect
hostname. The consequence of this would be that newly made access keys
won't work.
* Clarify API, change name, add validation errors
* Clarify description
* Remove the API response corresponding to a failed check against the new
hostname that it points to the same server
* Respond to review comments
* Rename endpoint and related functions
From the server's perspective, this does change the hostname for
existing access keys since on server load time (in the Server Manager)
we recalculate access key hostnames from the key repository.
* Respond to review comments
* Use version 1.2.0 since data limits is taking 1.1.0
* UI for setting the hostname for access key invitations (#553)
* Increase Shadowbox version for data limits experiment (#544)
* Return the port for new access keys from GET /server. (#552)
This was accidentally removed in #537.
* UI for setting the hostname for access key invitations
This also includes some random typo fixes and QOL improvements.
To test, you can use
export SB_IMAGE=cohenjongoogle/shadowbox:latest
yarn do shadowbox/docker/run
then in a different terminal
yarn do server_manager/electron_app/run
and add the server
* Add back in new files
Also fixes a backward compatibility issues for servers which don't
support changing the hostname
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Use DB-IP's Geolocation database instead of MaxMind's (#557)
* Use DB-IP's free IP-to-Country database instead of MaxMind's
This avoids the necesseity to either (1) bundle MaxMind's database in
our docker image or (2) require server admins to individually create
MaxMind accounts due to the new requirements for using GeoLite2
databases. See https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
* Add attribution to DB-IP for the GeoIP database
* Make sure that we deal with lag between the changeover of the current
month and release of new versions of the DB-IP database
* Respond to review comments
* Attribute DB-IP in the update script
* Respond to review comments
* Respond to review comments
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* Update to Typescript 3.7 (#558)
See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html for more information. Among the nice new features are optional chainging and null coalescing, and assertion functions, as well as some additional safety checks in the compiler
* Create an endpoint to change the server's hostname.
This is the backend only, and does not check if the hostname exists or points to a Shadowbox
server. Users have the responsibility of double checking that the
hostname and DNS if necessary are properly set up and specified.
* Updates
Changes validation to use regex.
Gets rid of a bad test
Uses paramtereized tests for better test output
Adds setHostname to AccessKeyRepository and calls it in the endpoint
* Integration tests
Also fixes missing dependency on ip-regex
* Remove validator from lockfile
* Ensure we correctly use Python 2 for Cloud SDK
* API for the new endpoint to change the server hostname. (#534)
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* API for the new endpoint to change the server hostname.
I am sending it up now so we can iterate on it while I'm busy
implementing the endpoint. I will merge it into the feature branch when
it's done as opposed as into master.
* Remove 404 and 406 error states. Checking for a functioning Shadowbox
server requires knowledge of the API prefix, which creates layering
challenges. The UI will be able to make these checks, but users who
call the API directly will have to be careful not to put in an incorrect
hostname. The consequence of this would be that newly made access keys
won't work.
* Clarify API, change name, add validation errors
* Clarify description
* Remove the API response corresponding to a failed check against the new
hostname that it points to the same server
* Respond to review comments
* Rename endpoint and related functions
From the server's perspective, this does change the hostname for
existing access keys since on server load time (in the Server Manager)
we recalculate access key hostnames from the key repository.
* Respond to review comments
* Use version 1.2.0 since data limits is taking 1.1.0
* Fix update_mmdb and the Docker image to work on Alpine (#559)
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* UI for setting the hostname for access key invitations
This also includes some random typo fixes and QOL improvements.
To test, you can use
export SB_IMAGE=cohenjongoogle/shadowbox:latest
yarn do shadowbox/docker/run
then in a different terminal
yarn do server_manager/electron_app/run
and add the server
* Add back in new files
Also fixes a backward compatibility issues for servers which don't
support changing the hostname
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Respond to review comments
* Fix messed up rebase
* merge
* Clear merge markers
Co-authored-by: alalamav <2132122+alalamav@users.noreply.github.com>
Co-authored-by: alalamav <2132122+alalamav@users.noreply.github.com>
* Fix the for loop in update_mmdb to be `dash` compatible
for x in {a..b} is bash-only, and alpine's default shell is `dash`.
* Fix other issues related to using musl/Busybox/dash
* Use `[[` instead of `((` for the branch
* Make sure to update to GNU coreutils in the image in order to use
`date --date`
* Respond to review comments
* Use DB-IP's free IP-to-Country database instead of MaxMind's
This avoids the necesseity to either (1) bundle MaxMind's database in
our docker image or (2) require server admins to individually create
MaxMind accounts due to the new requirements for using GeoLite2
databases. See https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
* Add attribution to DB-IP for the GeoIP database
* Make sure that we deal with lag between the changeover of the current
month and release of new versions of the DB-IP database
* Respond to review comments
* Attribute DB-IP in the update script
* Respond to review comments
* Respond to review comments
* Get public hostname from config file
* Tidy up
* Respond to Review Comments
At some point down the line I royally screwed up my git history and
reverted a bunch of changes. I'm not sure what or when, so I `git reset --hard 1cd28e4` and tried to redo my
past responses to comments from there.
* Export SB_PUBLIC_IP in cmd.sh
* respond to review comments
* Review response
* Set -x in the integration test
The integration test has been flaking from time to time on Travis with
no obvious failures, indicating this is happening unexpectedly outside a
`fail` call. `set -x` will help us diagnose when it happens again.
* Only show logs on test failure
* Correctly continue if test.sh fails
* Only cleanup the logfile on success. The logfile should stick around on
failure for easier sharing of test results. It will eventually get
cleaned up whenever the tmp directory gets cleaned.
This corresponds with the same change in outline-client
Tested:
yarn do {server_manager/test, shadowbox/test, shadowbox/integration_test/run, sentry_webhook/build, metrics_server/build}
* Allow the port fo rnew access keys to be changed from the UI
* Remove old TODOs
* Use correct log levels
* CSS formatting
* Use Number.isNan
* short circuit on no change and kill dead code
* Implement fakes, fix display bug
* fix typo
* Respond to code review
* Fix underline coloring
* Limit to numerical input
* Respond to review comments
* Review comments
* Disable editing key port for old servers (#513)
* Disable editing key port for old servers
* Use -1 instead of the current port number, nits
* Be more conservative with the response code check
* Use on-tap instead of on-click for the keys port input
* Rename "toggleFoo" to "setFoo"
* Use 1.0.0 instead of 0.2.0
* Respond to review comments. Also fixes a bug where, if the input was
invalid due to a server-side error, hitting Enter did nothing except
show a valid state
* Correct the previous bugfix
