chore: upgrade node to lts/hydrogen (#1365)

* chore: upgrade to lts/hydrogen

* update github workflows

* fix attempt #1

* ssl, restify upgrade

* more openssl options

* ah thanks sander, using middleware2

* fix ci

* reset package-lock.json

* revert middleware2

* fix optional chaining

* okay cool tests run, but fail

* partially update the node image (i can't find the other one)

* Update test.action.sh

* Update build.action.sh

* Update test.action.sh

* Update build.action.sh

* Update package.json

* Update webpack.config.js

* Update webpack.config.js

* Update build.action.sh

* Update build.action.sh

* Update package.json

* Update README.md

.github/workflows/build_and_test_debug.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies
@@ -44,7 +44,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies
@@ -70,7 +70,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies
@@ -93,7 +93,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies
@@ -116,7 +116,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies
@@ -138,7 +138,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies
@@ -160,7 +160,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies
@@ -182,7 +182,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies

.github/workflows/pull_request_checks.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v2.2.0
         with:
-          node-version: 16
+          node-version: 18
           cache: npm
 
       - name: Install NPM Dependencies

.nvmrc

@@ -1 +1 @@
-lts/gallium
+lts/hydrogen

README.md

@@ -33,8 +33,8 @@ The system comprises the following components:
 
 In order to build and run the code, you need the following installed:
 
-- [Node](https://nodejs.org/en/download/) LTS (`lts/gallium`, version `16.13.0`)
-- [NPM](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) (version `8.1.0`)
+- [Node](https://nodejs.org/en/download/) LTS (`lts/hydrogen`, version `18.16.0`)
+- [NPM](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) (version `9.5.1`)
 - Manager-specific
   - [Wine](https://www.winehq.org/download), if you would like to generate binaries for Windows.
 - Server-specific

package.json

@@ -24,8 +24,8 @@
     "typescript": "^4"
   },
   "engines": {
-    "node": "^16.13.0",
-    "npm": "^8.1.0"
+    "node": "^18.16.0",
+    "npm": "^9.5.1"
   },
   "scripts": {
     "action": "bash ./scripts/run_action.sh",

src/shadowbox/docker/build.action.sh

@@ -23,12 +23,12 @@ export ARCH=${ARCH:-x86_64}
 
 # Newer node images have no valid content trust data.
 # Pin the image node:16.18.0-alpine3.16 by hash.
-# See image at https://hub.docker.com/_/node/tags?page=1&name=16.18.0-alpine3.16
+# See image at https://hub.docker.com/_/node/tags?page=1&name=18.18.0-alpine3.18
 readonly NODE_IMAGE=$(
     if [[ "${ARCH}" == "x86_64" ]]; then
-        echo "node@sha256:264861cd2f785a2b727e9f908065e8d9e9358fcc1308da3cb207d9cba69afee2" 
+        echo "node@sha256:a0b787b0d53feacfa6d606fb555e0dbfebab30573277f1fe25148b05b66fa097" 
     elif [[ "${ARCH}" == "arm64" ]]; then
-        echo "node@sha256:e2aff82eea79469af43ddd121f1c8f8c91a501e838534bd3991e225401b2c38d" 
+        echo "node@sha256:b4b7a1dd149c65ee6025956ac065a843b4409a62068bd2b0cbafbb30ca2fab3b" 
     else
         echo "Unsupported architecture"
         exit 1