CERBERUS/outline-server
1
0
Fork 0
mirror of https://github.com/OutlineFoundation/outline-server.git synced 2026-05-13 13:58:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

build(manager): 👷 upgrade packages to fix manager's local build (#1101)

Browse source 
In this PR, I fixed two build errors when starting manager locally on macOS:

1. **Cannot find python** (caused by out-dated `electron-builder`)

> ```
> $ BUILD_ENV=development npm run action server_manager/electron_app/start mac
> ...
> + electron-builder --mac --config.mac.icon=icons/mac/icon.icns --projectDir=build/server_manager/electron_app/static --config.asarUnpack=server_manager/web_app/images --publish=never '--config.artifactName="Outline-Manager.${ext}"'
> ...
>     ⨯ Exit code: ENOENT. spawn /usr/bin/python ENOENT
> ...
> ```

2. **Cannot run `serve`** (caused by out-dated `webpack-cli`)

> ```
> $ npm run action server_manager/web_app/start
> ...
> TypeError: Class constructor ServeCommand cannot be invoked without 'new'
> ...
> ```

I also added [`@webpack-cli/serve`](https://www.npmjs.com/package/@webpack-cli/serve) as a global package because it is required by `webpack-cli`] when you run `npm run action server_manager/web_app/start`:

```
$ npm run action server_manager/web_app/start
...
Would you like to install serve? (That will run npm install -D @webpack-cli/serve) (yes/NO) : 
@webpack-cli/serve needs to be installed in order to run the command.
...
```
This commit is contained in:
J. Yi 2022-05-31 15:22:33 -04:00 • committed by GitHub
parent 95f679a8c9
commit c69c7167c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 1898 additions and 1344 deletions
Download patch file Download diff file Expand all files Collapse all files

3227
package-lock.json generated
View file

File diff suppressed because it is too large Load diff

1
package.json
View file

@ -5,6 +5,7 @@
"@types/jasmine": "^3.5.10",
"@typescript-eslint/eslint-plugin": "^5.14.0",
"@typescript-eslint/parser": "^5.14.0",
"@webpack-cli/serve": "^1.6.1",
"eslint": "^8.10.0",
"generate-license-file": "^1.2.0",
"husky": "^1.3.1",

6
src/server_manager/README.md
View file

@ -5,15 +5,17 @@
To run the Outline Manager Electron app:
```
npm run action server_manager/electron_app/start
npm run action server_manager/electron_app/start ${PLATFORM}
```
To run the Outline Manager Electron app with a development build (code not minified):
```
BUILD_ENV=development npm run action server_manager/electron_app/start
BUILD_ENV=development npm run action server_manager/electron_app/start ${PLATFORM}
```
Where `${PLATFORM}` is one of `linux`, `mac`, `windows`.
## Development Server
To run the Outline Manager as a web app on the browser and listen for changes:

4
src/server_manager/base.webpack.js
View file

@ -36,7 +36,9 @@ exports.makeConfig = (options) => {
devtool: 'inline-source-map',
// Run the dev server with `npm run webpack-dev-server --workspace=outline-manager --open`
devServer: {
overlay: true,
client: {
overlay: true,
},
},
output: {path: OUTPUT_BASE, filename: 'main.js'},
module: {

4
src/server_manager/package.json
View file

@ -79,7 +79,7 @@
"copy-webpack-plugin": "^5.1.1",
"css-loader": "^3.5.3",
"electron": "18.1.0",
"electron-builder": "~22.10.5",
"electron-builder": "~23.0.3",
"electron-icon-maker": "^0.0.4",
"electron-notarize": "^0.2.1",
"electron-to-chromium": "^1.4.122",
@ -99,7 +99,7 @@
"style-loader": "^1.2.1",
"ts-loader": "^7.0.1",
"webpack": "^4.43.0",
"webpack-cli": "^3.3.11",
"webpack-cli": "^4.9.2",
"webpack-dev-server": "^4.9.0"
},
"resolutions": {