CERBERUS/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2026-05-13 08:46:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Simplify function: return const strings, not static buffer

Browse source
This commit is contained in:
dmiller 2026-04-30 22:02:01 +00:00
parent 3f5a1bd4c1
commit 6d95d721e0
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
libnetutil/netutil.cc
View file

@ -1989,14 +1989,11 @@ int islocalhost(const struct sockaddr_storage *ss) {
}
char *nexthdrtoa(u8 nextheader, int acronym){
static char buffer[129];
memset(buffer, 0, 129);
static const char *nexthdrtoa(u8 nextheader, int acronym){
#define HDRTOA(num, short_name, long_name) \
case num: \
strncpy(buffer, acronym ? short_name : long_name, 128);\
return (acronym ? short_name : long_name);\
break;
switch(nextheader){
@ -2151,13 +2148,12 @@ switch(nextheader){
HDRTOA(253, "experimental1", "Use for experimentation and testing")
HDRTOA(254, "experimental2", "Use for experimentation and testing")
default:
strncpy(buffer, acronym ? "unknown" : "Unknown protocol", 128);\
break;
} /* End of switch */
return buffer;
return (acronym ? "unknown" : "Unknown protocol");
} /* End of nexthdrtoa() */