mirror of
https://github.com/kovidgoyal/kitty.git
synced 2026-10-25 06:33:09 +00:00
a1d24028b8
Without this, kitty fails to compile:
```
glfw/cocoa_init.m:462:14: error: case value not in enumerated type
'NSEventModifierFlags' (aka 'enum NSEventModifierFlags')
[-Werror,-Wswitch]
case (NSEventModifierFlagShift | NSEventModifierFlagOption):
^
glfw/cocoa_init.m:465:14: error: case value not in enumerated type
'NSEventModifierFlags' (aka 'enum NSEventModifierFlags')
[-Werror,-Wswitch]
case (NSEventModifierFlagShift | NSEventModifierFlagCommand):
^
```
I thought about changing the type of the `modifierFlags` function parameter from `NSEventModifierFlags` to `NSUInteger` since `NSEventModifierFlags` is defined as an enum according to https://developer.apple.com/documentation/appkit/nseventmodifierflags?language=objc and is technically not the proper type for a bit field. But since Apple themselves define `modifierFlags` as `NSEventModifierFlags` according to https://developer.apple.com/documentation/appkit/nsevent/1534405-modifierflags?language=objc, I think the fix in this commit is better.
This warning was introduced with commit
|
||
|---|---|---|
| .. | ||
| __init__.py | ||
| backend_utils.c | ||
| backend_utils.h | ||
| cocoa_init.m | ||
| cocoa_joystick.h | ||
| cocoa_joystick.m | ||
| cocoa_monitor.m | ||
| cocoa_platform.h | ||
| cocoa_window.m | ||
| context.c | ||
| dbus_glfw.c | ||
| dbus_glfw.h | ||
| egl_context.c | ||
| egl_context.h | ||
| glfw.py | ||
| glfw3.h | ||
| glx_context.c | ||
| glx_context.h | ||
| ibus_glfw.c | ||
| ibus_glfw.h | ||
| init.c | ||
| input.c | ||
| internal.h | ||
| linux_desktop_settings.c | ||
| linux_desktop_settings.h | ||
| linux_joystick.c | ||
| linux_joystick.h | ||
| linux_notify.c | ||
| linux_notify.h | ||
| main_loop.h | ||
| mappings.h | ||
| memfd.h | ||
| monitor.c | ||
| monotonic.c | ||
| nsgl_context.h | ||
| nsgl_context.m | ||
| null_init.c | ||
| null_joystick.c | ||
| null_joystick.h | ||
| null_monitor.c | ||
| null_platform.h | ||
| null_window.c | ||
| osmesa_context.c | ||
| osmesa_context.h | ||
| posix_thread.c | ||
| posix_thread.h | ||
| source-info.json | ||
| vulkan.c | ||
| window.c | ||
| wl_client_side_decorations.c | ||
| wl_client_side_decorations.h | ||
| wl_cursors.c | ||
| wl_cursors.h | ||
| wl_init.c | ||
| wl_monitor.c | ||
| wl_platform.h | ||
| wl_text_input.c | ||
| wl_text_input.h | ||
| wl_window.c | ||
| x11_init.c | ||
| x11_monitor.c | ||
| x11_platform.h | ||
| x11_window.c | ||
| xkb-compat-shim.h | ||
| xkb_glfw.c | ||
| xkb_glfw.h | ||