Commit graph

18 commits

Author SHA1 Message Date
Kovid Goyal
6d8f7ac14f
Cleanup previous PR
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
Let preview renderers supply extra cache key data instead of checking for
the cmd_renderer type. Include the command line in the key for custom
previews and the video_preview settings in the key for video thumbnails,
so that changing them no longer shows stale previews. GetPath and AddPath
now take this extra key data, replacing GetPathWithAlias.

Track the entry each path uses per extra key, so that previews of one file
with different settings do not evict each other. Do not remove an entry
while another path, such as another symlink to the same file, still uses
it. Cache hits are now recorded so that such shared entries are known.
Failing to remove an orphaned entry on a cache hit no longer turns the hit
into an error.

Fix ensure_entries() discarding unwritten changes when the entries file
does not exist yet, which lost the first path recorded in a new cache.
Also reset the path map when clearing the cache.
2026-11-11 21:26:01 +05:30
Zhizhen He
a1f5604cc2
choose-files: Keep custom preview caches separate for symlinks
Custom preview commands receive the selected path. Include that path
in their cache key so that symlinks to the same file can have different
previews. Keep the resolved target in the key so retargeting a link
still invalidates its entry.
2026-11-11 23:32:42 +08:00
Kovid Goyal
7a751292bb
Cleanup previous PR
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
Replace exported get_dir files atomically so paths returned by Get/Add
never briefly vanish while another worker re-exports the same key.
Don't panic in Get for a key folder missing from entries.json.
Propagate errors from unlocking, document the lock()/unlock() contract,
and fix the NewDiskCache lock error test which checked the wrong cache
2026-10-11 12:11:06 +05:30
Zhizhen He
d91ab369e4
Fix locking during concurrent disk cache access 2026-10-11 12:56:24 +08:00
Kovid Goyal
fae50137a9
Add a clear cache action 2025-11-23 12:15:29 +05:30
Kovid Goyal
49d8b1a9d0
More work on image preview rendering 2025-10-08 22:00:12 +05:30
Kovid Goyal
c2e75ba466
Fix disk cache not reading inode
Also use a faster atomic update mechanism
2025-10-08 08:35:35 +05:30
Kovid Goyal
16cdcf8cf8
Use inode number and size for more robust entries change tracking 2025-10-08 07:28:02 +05:30
Kovid Goyal
a6335777d9
disk cache: add a path based API
This allows maintaining only a single cache entry per path when the
path's contents change.
2025-10-08 06:41:12 +05:30
Kovid Goyal
1f37f065ab
Improve API of disk cache
Allow getting all keys and also return get result for added keys
2025-10-07 13:01:09 +05:30
Kovid Goyal
224ccb170a
Micro optimisation 2025-10-07 09:23:22 +05:30
Kovid Goyal
328745cad9
removing a non-existent item from disk cache is not an error 2025-10-07 09:16:30 +05:30
Kovid Goyal
5d1ce327e0
Ensure adds to disk cache are atomic 2025-10-07 09:14:14 +05:30
Kovid Goyal
712faa7aa5
Fix pruning on DiskCache object creation 2025-09-30 13:18:00 +05:30
Kovid Goyal
8fdbf8d7da
Make the paths returned by DiskCache stable even if the parent entry is removed/pruned for the life of the process 2025-09-30 12:53:08 +05:30
Kovid Goyal
ca0ff68d8e
More tests for disk cache 2025-09-30 11:16:49 +05:30
Kovid Goyal
d7199f1f75
Start working on tests for disk cache 2025-09-28 21:35:36 +05:30
Kovid Goyal
30f7ed76c1
Start work on disk cache for choose files preview caching 2025-09-28 09:49:16 +05:30