CERBERUS/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2026-06-27 19:31:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Refine macOS crash symbolization

Browse source
This commit is contained in:
copilot-swe-agent[bot] 2026-06-24 01:17:22 +00:00 • committed by GitHub
parent 386f1343a6
commit c6ebe2e786
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 22 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

30
.github/workflows/macos_crash_report.py vendored
View file

@ -263,17 +263,22 @@ class UserModeCrashReport(CrashReportBase):
@cached_property
def local_images(self) -> Mapping[str, str]:
result = {}
for path in (
'build/kitty/fast_data_types.so',
'build/kitty/kitten',
'kitty/launcher/kitty',
'kitty.app/Contents/MacOS/kitty',
):
for path in ('build/kitty', 'kitty/launcher', 'kitty.app/Contents/MacOS'):
abspath = os.path.abspath(path)
if os.path.exists(abspath):
result[os.path.basename(abspath)] = abspath
if not os.path.isdir(abspath):
continue
for entry in os.scandir(abspath):
if entry.is_file():
result.setdefault(entry.name, entry.path)
return result
@property
def symbolication_errors(self) -> List[str]:
ans = getattr(self, '_symbolication_errors', None)
if ans is None:
ans = self._symbolication_errors = []
return ans
def _parse_field(self, name: str) -> str:
name += ':'
for line in self._data.split('\n'):
@ -294,6 +299,11 @@ class UserModeCrashReport(CrashReportBase):
capture_output=True, text=True
)
if cp.returncode != 0:
err = cp.stderr.strip()
if err:
msg = f'{os.path.basename(local_image)}: {err}'
if msg not in self.symbolication_errors:
self.symbolication_errors.append(msg)
return None
line = cp.stdout.strip()
if not line or line.startswith('0x'):
@ -461,6 +471,10 @@ class UserModeCrashReport(CrashReportBase):
if source is not None:
result += f'\n\t => {source}'
result += '\n'
if self.symbolication_errors:
result += '\n' + bold('Symbolication errors:\n')
for msg in self.symbolication_errors:
result += f'\t{msg}\n'
return result