From 21fa5bb1ce230f595c1c4fa1dfa9bca8a1a2e5ca Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sat, 23 Aug 2025 07:32:33 +0530 Subject: [PATCH] macOS: focusing of minimized window broken This was done to fix #8913 in d7c2cdc. Explicitly de-miniaturize before making key. --- glfw/cocoa_window.m | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/glfw/cocoa_window.m b/glfw/cocoa_window.m index 93f500cb6..45a52f139 100644 --- a/glfw/cocoa_window.m +++ b/glfw/cocoa_window.m @@ -2291,8 +2291,13 @@ int _glfwPlatformWindowBell(_GLFWwindow* window UNUSED) void _glfwPlatformFocusWindow(_GLFWwindow* window) { - // Make us the active application + if (_glfwPlatformWindowIconified(window)) { + // miniaturized windows return false in canBecomeKeyWindow therefore + // unminiaturize first + [window->ns.object deminiaturize:nil]; + } if ([window->ns.object canBecomeKeyWindow]) { + // Make us the active application [NSApp activateIgnoringOtherApps:YES]; [window->ns.object makeKeyAndOrderFront:nil]; }