Enea D'Angiò
d36c8ebce8
Reduce cognitive complexity of RemoveFromPlaylist
2026-07-16 21:03:29 +02:00
Enea D'Angiò
6883cd0969
Fix play queue index handling in SyncPlay
...
Three index bugs in PlayQueueManager, two of which leave
PlayingItemIndex out of bounds, making every subsequent Buffering/Ready
request throw and leaving the group unusable until it empties:
- RemoveFromPlaylist did not compensate for removed items preceding the
playing item: removing the playing item together with earlier items
could select the wrong item or crash with an out-of-bounds index.
- Next/Previous on an empty playlist with RepeatOne/RepeatAll reported
success or set PlayingItemIndex to 0 on an empty list, crashing
downstream in Group and corrupting the index.
- SetPlayingItemByIndex accepted an index equal to the playlist count
(latent off-by-one, callers currently pre-validate).
2026-07-04 11:38:05 +02:00
Cody Robibero
9a0dfc00f1
Add all websocket messages to generated openapi spec ( #9682 )
...
* Add all websocket messages to generated openapi spec
* Use oneOf
* JsonIgnore ServerId
* Oops
* Add discriminators
* Add WebSocketMessage container for Inbound and Outbound messages
2023-06-10 07:28:21 -06:00
Stepan Goremykin
910617bbc3
Remove redundant 'else' keywords
2023-04-06 19:38:34 +02:00
Bond_009
52194f56b5
Replace != null with is not null
2022-12-05 15:01:13 +01:00
luz paz
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Bond_009
dc8feca6bb
Remove duplicate Fisher–Yates shuffle impl
2021-10-08 15:20:11 +02:00
Bond_009
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
2021-05-07 00:39:20 +02:00
Ionut Andrei Oanca
cbf70e7a03
Change type of PlaylistItemId to Guid
2020-12-04 20:15:16 +01:00
Ionut Andrei Oanca
a3ca36cb54
Review logging and minor changes in SyncPlay
2020-11-16 20:05:57 +01:00
Ionut Andrei Oanca
c7e53bce2f
Patch data-races and minor changes in SyncPlay
2020-11-15 17:30:28 +01:00
Ionut Andrei Oanca
5d77f422f0
Hide some property setters, init null values, update namespaces
2020-11-14 23:40:01 +01:00
Ionut Andrei Oanca
83333e1fe8
Replace foreach loop with FindIndex
2020-11-14 17:07:52 +01:00
Ionut Andrei Oanca
1dbc91978e
Address requested changes and fix some warnings
2020-11-14 12:33:54 +01:00
Ionut Andrei Oanca
019bc19aa4
Minor changes to play queue in Syncplay group
2020-10-22 16:32:15 +02:00
Ionut Andrei Oanca
0c735a0395
Address requested changes by review
2020-10-22 16:12:27 +02:00
Ionut Andrei Oanca
1cabe82b59
Rewrite play queue logic of SyncPlay group
2020-10-22 16:12:27 +02:00
BaronGreenback
f6ab98507e
Update MediaBrowser.Controller/SyncPlay/Queue/PlayQueueManager.cs
2020-10-22 13:29:09 +01:00
Ionut Andrei Oanca
36fee4e60a
Minor fixes
2020-10-21 16:42:57 +02:00
Ionut Andrei Oanca
93cbf64f88
End comments with a period
2020-10-21 15:46:50 +02:00
Ionut Andrei Oanca
8819a9d478
Add playlist-sync and group-wait to SyncPlay
2020-10-16 12:06:29 +02:00
