mirror of
https://github.com/EbookFoundation/free-programming-books.git
synced 2026-10-20 20:21:33 +00:00
Fix comment on PR workflow (#13188)
* remove specific node version so default is 24 * change success to completed in comment pr workflow
This commit is contained in:
parent
8206f6fce0
commit
f026adec83
2 changed files with 4 additions and 5 deletions
2
.github/workflows/comment-pr.yml
vendored
2
.github/workflows/comment-pr.yml
vendored
|
|
@ -13,7 +13,7 @@ jobs:
|
|||
runs-on: ubuntu-latest
|
||||
if: >
|
||||
${{ github.event.workflow_run.event == 'pull_request' &&
|
||||
github.event.workflow_run.conclusion == 'success' }}
|
||||
github.event.workflow_run.conclusion == 'completed' }}
|
||||
steps:
|
||||
- name: 'Download artifact'
|
||||
uses: actions/github-script@v8
|
||||
|
|
|
|||
7
.github/workflows/fpb-lint.yml
vendored
7
.github/workflows/fpb-lint.yml
vendored
|
|
@ -14,11 +14,9 @@ jobs:
|
|||
- uses: actions/checkout@v5
|
||||
- name: Use Node.js
|
||||
uses: actions/setup-node@v6
|
||||
with:
|
||||
node-version: '16.x'
|
||||
- run: npm install -g free-programming-books-lint
|
||||
|
||||
- name: Pull Request
|
||||
- name: Run linter
|
||||
run: |
|
||||
fpb-lint books casts courses more &> output.log
|
||||
|
||||
|
|
@ -29,7 +27,8 @@ jobs:
|
|||
echo ${{ github.event.pull_request.html_url }} > ./pr/PRurl
|
||||
cat output.log | sed -E 's:/home/runner/work/free-programming-books/|⚠.+::' | uniq > ./pr/error.log
|
||||
|
||||
- uses: actions/upload-artifact@v7
|
||||
- name: Upload artifact
|
||||
uses: actions/upload-artifact@v7
|
||||
if: always()
|
||||
with:
|
||||
name: pr
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue