caddy/modules/caddyhttp/reverseproxy
Julien Voisin 49d7187c1b
caddyhttp: presize buffers in hot paths to reduce allocations (#7842)
* caddyhttp: presize buffers in hot paths to reduce allocations

Right-size three per-request allocations that previously grew from a
nil/empty backing array, causing repeated reallocation:

- CleanPath: pre-Grow the strings.Builder used when slash collapsing is
  disabled, instead of letting it reallocate as runes are appended
- headers: presize the rewritten value slice in HeaderOps.ApplyTo's Set
  loop instead of appending from nil
- reverseproxy: presize the weights slice in WeightedRoundRobinSelection
  .Select

This commit also adds benchmarks exercising each path. Measured with benchstat
with count=20 and GOMAXPROCS=1, with p=0.000:

                                    sec/op                  B/op              allocs/op
CleanPathNoCollapse       1013.4n -> 828.6n  (-18.23%)  120->64  (-46.67%)   4->1  (-75.00%)
HeaderOpsApplyToSet       1262.0n -> 955.8n  (-24.27%)  255->152 (-40.39%)   9->6  (-33.33%)
WeightedRoundRobinSelect   215.8n -> 200.3n  ( -7.20%)  112->96  (-14.29%)   2->2  (N/A)

* caddyhttp: presize strings.Builder in query rewrite and path matcher

Two builders whose output size is bounded by a known input length were
growing from empty, causing repeated reallocation. Seed each with a
capacity hint:

- rewrite.buildQueryString: pre-Grow to len(qs) (runs per request when
  rewrite query manipulation is configured)
- MatchPath.matchPatternWithEscapeSequence: pre-Grow to len(escapedPath)
  (reached only when a path pattern contains % escape sequences)

Adds a benchmark for buildQueryString, measured with benchstat:

BuildQueryString:
	- sec/op  965.2n -> 743.3n  (-22.99%)
	- B/op 248->80  (-67.74%)
	- allocs/op 5->1  (-80.00%)

The builder previously reallocated four times per call. The matcher path
is cold and not separately benchmarked.

* chore: add benchmark headers

---------

Signed-off-by: Julien Voisin <jvoisin@users.noreply.github.com>
(cherry picked from commit c8492563ee)
2026-11-04 18:05:11 -05:00
..
fastcgi fastcgi: reject Win 8.3 aliases and alt data streams paths (#8356) 2026-11-04 18:05:11 -05:00
forwardauth forwardauth: error on duplicate uri subdirective (#7814) 2026-06-10 23:31:04 -04:00
active_health_test.go reverseproxy: replace only known placeholders in health check body (#8003) 2026-09-09 08:48:08 -06:00
addresses.go core: Implement socket activation listeners (#6573) 2024-09-30 10:55:03 -06:00
addresses_test.go reverseproxy: do not parse upstream address too early if it contains replaceble parts (#5695) 2023-08-05 23:30:02 +02:00
admin.go reverseproxy: Track dynamic upstreams, enable passive healthchecking (#7539) 2026-03-04 15:05:26 -05:00
admin_test.go reverseproxy: Track dynamic upstreams, enable passive healthchecking (#7539) 2026-03-04 15:05:26 -05:00
ascii.go
ascii_test.go filesystem: Globally declared filesystems, fs directive (#5833) 2024-01-13 20:12:43 +00:00
buffering_test.go reverseproxy: Don't drop read errors with unlimited buffers (#8207) 2026-11-03 00:53:18 -05:00
caddyfile.go feat: implement the Incremental header field (RFC 10036) (#8020) 2026-10-02 20:59:34 -04:00
client_disconnect_test.go reverseproxy: log HTTP/3 client cancellations at debug level (#8135) 2026-11-03 00:52:58 -05:00
command.go cmd: prevent commas in header values from being split (#7268) 2025-09-22 21:12:06 -06:00
copyresponse.go reverseproxy: strip hop-by-hop headers when copying response headers (#8270) 2026-11-03 00:53:19 -05:00
copyresponse_test.go reverseproxy: strip hop-by-hop headers when copying response headers (#8270) 2026-11-03 00:53:19 -05:00
dynamic_upstreams_test.go reverseproxy: Track dynamic upstreams, enable passive healthchecking (#7539) 2026-03-04 15:05:26 -05:00
handleresponse_test.go reverseproxy: close upstream body when handle_response status is invalid (#8318) 2026-11-03 18:21:22 -05:00
headers_test.go reverseproxy: strip hop-by-hop headers from interim responses (#8256) 2026-11-03 00:53:19 -05:00
healthchecks.go reverseproxy: replace only known placeholders in health check body (#8003) 2026-09-09 08:48:08 -06:00
hopheaders_test.go Merge commit from fork 2026-06-12 12:39:01 -06:00
hosts.go reverseproxy: isolate active health-check state per distinct check config (#7916) 2026-08-12 15:20:15 +10:00
httptransport.go caddytls: validate curve and protocol names, compare protocol IDs (#8266) 2026-11-03 00:53:19 -05:00
httptransport_test.go caddytls: validate curve and protocol names, compare protocol IDs (#8266) 2026-11-03 00:53:19 -05:00
incremental_test.go feat: implement the Incremental header field (RFC 10036) (#8020) 2026-10-02 20:59:34 -04:00
metrics.go reverseproxy: ignore duplicate collector registration error (#6820) 2025-02-04 10:55:30 +03:00
passive_health_test.go reverseproxy: Track dynamic upstreams, enable passive healthchecking (#7539) 2026-03-04 15:05:26 -05:00
prepare_request_bench_test.go reverseproxy: reduce allocation/CPU overhead in request hot paths (#7925) 2026-08-10 15:49:55 +10:00
request_trailers_test.go reverseproxy: preserve request trailer values (#8246) 2026-11-03 00:53:19 -05:00
retries_test.go reverseproxy: retry dial errors wrapped by a forward proxy (#8264) 2026-11-03 00:53:19 -05:00
reverseproxy.go reverseproxy: close upstream body when handle_response status is invalid (#8318) 2026-11-03 18:21:22 -05:00
selectionpolicies.go caddyhttp: presize buffers in hot paths to reduce allocations (#7842) 2026-11-04 18:05:11 -05:00
selectionpolicies_bench_test.go caddyhttp: presize buffers in hot paths to reduce allocations (#7842) 2026-11-04 18:05:11 -05:00
selectionpolicies_test.go reverseproxy: skip unavailable upstream with a single weighted_round_robin weight (#8320) 2026-11-03 18:21:22 -05:00
streaming.go caddyhttp: optimise header access and fix encoding negotiation (#8025) 2026-11-03 00:53:19 -05:00
streaming_test.go reverseproxy: close backend body and hijacked socket on upgrade setup failures (#8269) 2026-11-03 00:53:19 -05:00
upstreams.go reverseproxy: preallocate upstream slices with known sizes (#7926) 2026-08-10 15:51:50 +10:00
upstreams_bench_test.go reverseproxy: preallocate upstream slices with known sizes (#7926) 2026-08-10 15:51:50 +10:00
upstreams_test.go chore: upgrade .golangci.yml and workflow to v2 (#6924) 2025-06-03 02:24:32 +03:00