Danny Avila ac913aa886 🔐 chore: Skills Permissions Housekeeping, Reachable Admin Dialog + Defaults Tests (#12766) ... * 🔐 chore: Skills permissions housekeeping — reachable admin dialog + defaults tests Phase 9 housekeeping pass. Skills was already gated on `PermissionTypes.SKILLS` (seeded from `interface.skills`) and `AgentCapabilities.skills` everywhere it matters, but two smaller parity gaps with Prompts/Memory/MCP remained: - The skills admin settings dialog had no UI entry point. The only mount was inside an unused `FilterSkills` component, so admins had no way to reach the role-permissions editor for skills. Mounted it in `SkillsAccordion` gated on `SystemRoles.ADMIN`, matching the `PromptsAccordion` pattern. - No regression lock on skill permission defaults. `roles.spec.ts` asserted structural completeness but not the specific shape — a future refactor could silently flip ADMIN's `USE/CREATE/SHARE/SHARE_PUBLIC` to false or drop SKILLS from USER defaults without failing. Added explicit Skills assertions for both roles. - No lock on `AgentCapabilities.skills` being in `defaultAgentCapabilities`. Added an assertion in `endpoints.spec.ts`. * 🩹 fix: Remove duplicate `const appConfig` in Responses createResponse The Skills polish commit (#12760) added `const appConfig = req.config;` at line 381 inside the try block of `createResponse`, without noticing that the earlier drive-by fix (2463b6acd) already declared it at the function top (line 283). The second `const` creates a new block-scoped binding inside the try, so earlier references within the same block (e.g. line 348's `appConfig?.endpoints?.[EModelEndpoint.agents]?.allowedProviders`) now hit the TDZ instead of the outer binding and throw `ReferenceError: Cannot access 'appConfig' before initialization` — which the outer try/catch then swallows into a generic 500. This surfaced as all six token-usage tests in `api/server/controllers/agents/__tests__/responses.unit.spec.js` failing with `mockRecordCollectedUsage` never being called (because the throw skips past the `recordCollectedUsage(...)` call). Dropping the inner re-declaration restores the full control flow. All 11 tests in the file pass again. * 🧹 refactor: Address review nits on Phase 9 housekeeping - Move the `defaultAgentCapabilities` regression test out of the `createEndpointsConfigService` describe block and into its own top-level describe. It tests a module constant and has no relationship to the service factory; nesting was misleading and made it easier to accidentally drop if the service tests are later restructured. - Re-order local imports in `SkillsAccordion.tsx` longest-to-shortest per AGENTS.md convention (`SkillsSidePanel` 48 chars before `useAuthContext` 41 chars).		2026-04-25 04:02:01 -04:00
..
controllers	🔐 chore: Skills Permissions Housekeeping, Reachable Admin Dialog + Defaults Tests (#12766)	2026-04-25 04:02:01 -04:00
middleware	🧬 feat: Scaffold Skills CRUD with ACL Sharing and File Schema (#12613)	2026-04-25 04:01:59 -04:00
routes	🎚️ feat: Per-User Skill Active/Inactive Toggle with Ownership-Aware Defaults (#12692)	2026-04-25 04:02:00 -04:00
services	🔌 refactor: Decouple bash_tool from Per-User CODE_API_KEY (#12712)	2026-04-25 04:02:01 -04:00
utils	📜 feat: Skills UI + Initial E2E CRUD / Sharing (#12580)	2026-04-25 04:02:00 -04:00
cleanup.js	🧹 refactor: Tighten Config Schema Typing and Remove Deprecated Fields (#12452)	2026-03-29 01:10:57 -04:00
experimental.js	🧬 feat: Scaffold Skills CRUD with ACL Sharing and File Schema (#12613)	2026-04-25 04:01:59 -04:00
index.js	🧬 feat: Scaffold Skills CRUD with ACL Sharing and File Schema (#12613)	2026-04-25 04:01:59 -04:00
index.spec.js	🚦 fix: 404 JSON Responses for Unmatched API Routes (#11976)	2026-02-27 22:49:54 -05:00
socialLogins.js	🔐 feat: Admin Auth Support for SAML and Social OAuth Providers (#12472)	2026-03-30 22:49:44 -04:00