LibreChat/e2e/benchmarks-fade/speech.perf.spec.ts
Danny Avila 461a4c2c52
🔇 fix: Stop Every Row's Read-Aloud Element From Loading the Page (#18168)
Each assistant row mounts a hidden `<audio autoplay>` for its read-aloud
button and passed it `src={audioRef.current?.src}`. An element with no
source reports `''`, so the row's second render wrote an empty `src`, and
its third wrote that back as the document's base URL. Both start a media
load: the first fails at once, the second fetches the app's HTML and fails
to decode it. A thread of 250 rows did that twice per row each time the
thread was opened and a run began.

The player assigns the source itself when speech starts, so the prop
carried nothing. Without it React never touches the attribute.

The live-run benchmarks ran with read-aloud off and so never mounted these
elements. They now leave it on, as the app does, and `speech.perf.spec.ts`
counts the media errors and requests the rows make.
2026-11-14 15:02:16 -05:00

94 lines
3.5 KiB
TypeScript

import { test } from '@playwright/test';
import { formatFrameCost, traceFrames } from './trace';
import { CONVOS, awaitRunEnd, chatName, draft, openChat, removeChats, seedChat } from './chats';
/**
* What the read-aloud control costs a long thread.
*
* Every assistant row carries a hidden `<audio>` element for its read-aloud button. Nothing is
* meant to load into it until the button is pressed, so it should cost the page nothing: no
* media error, no request, and no main-thread time after the thread has mounted or a run has
* started. `FADE_PERF_TTS=0` turns read-aloud off, for a thread without the elements.
*/
test.use({ trace: 'off', video: 'off' });
const PROMPT = process.env.FADE_PERF_PROMPT ?? 'say hello';
const SETTLE_MS = 12_000;
declare global {
interface Window {
__AUDIO_ERRORS__?: number[];
}
}
test.describe('read-aloud elements in a long thread', () => {
test.skip(CONVOS.length === 0, 'FADE_PERF_CHATS names no exported conversation');
test.afterAll(removeChats);
for (const convo of CONVOS) {
test(`audio elements of ${chatName(convo)}`, async ({ page, browser }) => {
await seedChat(convo);
await page.addInitScript(() => {
window.__AUDIO_ERRORS__ = [];
document.addEventListener(
'error',
(event) => {
if (event.target instanceof HTMLAudioElement) {
window.__AUDIO_ERRORS__?.push(Math.round(performance.now()));
}
},
true,
);
});
const media: string[] = [];
page.on('request', (request) => {
if (request.resourceType() === 'media') {
media.push(new URL(request.url()).pathname);
}
});
const read = () =>
page.evaluate(() => ({
audio: document.querySelectorAll('audio').length,
withSrc: document.querySelectorAll('audio[src]').length,
errors: window.__AUDIO_ERRORS__?.length ?? 0,
last: window.__AUDIO_ERRORS__?.at(-1) ?? 0,
first: window.__AUDIO_ERRORS__?.[0] ?? 0,
}));
const report = async (name: string) => {
const now = await read();
console.log(
`${name.padEnd(28)} audio=${now.audio} withSrc=${now.withSrc} errors=${now.errors} ` +
`(first ${now.first}ms, last ${now.last}ms) mediaRequests=${media.length}`,
);
};
const size = await openChat(page, convo);
console.log(`\n${chatName(convo)}: ${size.rows} rows, ${size.nodes} elements`);
await report('after the thread mounted');
const settled = await traceFrames(browser, page, () => page.waitForTimeout(SETTLE_MS));
console.log(formatFrameCost('open thread, held still', settled));
await report('after holding still');
await draft(page, PROMPT);
const run = await traceFrames(browser, page, async () => {
await page.keyboard.press('Enter');
await awaitRunEnd(page);
await page.waitForTimeout(SETTLE_MS);
});
console.log(formatFrameCost('one short run, then held still', run));
await report('after one run');
await draft(page, PROMPT);
const second = await traceFrames(browser, page, async () => {
await page.keyboard.press('Enter');
await awaitRunEnd(page);
await page.waitForTimeout(SETTLE_MS);
});
console.log(formatFrameCost('a second run, then held still', second));
await report('after a second run');
console.log(`media request paths: ${JSON.stringify([...new Set(media)])}`);
});
}
});