mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-18 14:08:21 +00:00
* feat: Extend the Audit Action Vocabulary to Admin, Sync and Credential Mutations * feat: Audit Admin Role, Group and Config Mutations Role deletion now removes the role's grants, ACL entries and config overrides before the role itself and returns ROLE_CLEANUP_FAILED instead of success when any of them fails, so a recreated role cannot inherit leftover privileges. * feat: Audit IdP and Startup Role Changes * fix: Keep the Startup Role Sync Running When Its Audit Verification Read Fails * test: Cover Admin Role Audit Trail End to End * fix: Audit a Remote Agent Role Sync Only After It Persists * fix: Restore Role Dependents When Role Deletion Fails Midway * fix: Restore Role Dependents Only When the Role Still Exists * style: Sort Role Admin Imports * fix: Keep the ACL Snapshot When Role Cleanup Fails Ambiguously * test: Read Role Audit Entries From the Audit Log Route * fix: Audit Only Real Membership Changes and Restore Deleted Role Config in Full * fix: Restore Deleted Role Grants in Full and Sanitize Audit Write Logging * fix: Audit and Report a Role Deletion Confirmed After a Lost Response * fix: Never Restore Dependents Onto a Recreated Role * fix: Snapshot Role Dependents Before Deleting and Detect Membership Changes Atomically * fix: Restore From the Data a Cascade Step Actually Removed * fix: Restore Only Config Overrides When a Role Delete Fails * fix: Log Only Safe Metadata When the Startup Audit Read Fails * fix: Audit Grants Removed by a Failed Role Delete * fix: Audit Removed Grants on Unverifiable Role Delete Exits * fix: Honor Fail-Closed Auditing in the Admin Config, Group and Role Routes * fix: Bind Role Deletion to the Captured Id and Audit Only Atomic Role and Config Changes * fix: Skip the Config Restore When the Targeted Role Is Gone * fix: Audit Initial Group Members and Skip No-Op Role Description Updates * fix: Record Role Deletion as Pending Before Cleanup and Append Its Outcome * fix: Audit Reassigned Role Members and Return the Persisted Config After a Tracked Toggle * fix: Keep a Committed Role Deletion Successful When Cascade Audit Writes Fail * fix: Decide Group Update Audits From the Atomic Write and Sanitize Permission Update Logs * fix: Audit Grants From a Snapshot, Fail on Member Lookup Errors and Chunk Member Audit Entries * fix: Audit Group Deletion Members and Previous Role Removal, Abort on Grant Snapshot Failure * fix: Invalidate Config Caches After Partial Secret Writes * fix: Retry Failed Cascade Restores, Report Changed Group Fields and Audit Every Reassigned Member * fix: Log Safe Metadata When Cache Invalidation Fails After a Partial Write * fix: Keep Error Messages Out of the Audit Write Failure Log * style: Sort Audit Log Spec Imports * fix: Sanitize Admin Handler Error Logs and Dispatch System Audit Writes Without Waiting
180 lines
5.7 KiB
JavaScript
180 lines
5.7 KiB
JavaScript
const express = require('express');
|
|
const { logger, SystemCapabilities } = require('@librechat/data-schemas');
|
|
const {
|
|
SystemRoles,
|
|
roleDefaults,
|
|
PermissionTypes,
|
|
agentPermissionsSchema,
|
|
promptPermissionsSchema,
|
|
memoryPermissionsSchema,
|
|
mcpServersPermissionsSchema,
|
|
marketplacePermissionsSchema,
|
|
peoplePickerPermissionsSchema,
|
|
remoteAgentsPermissionsSchema,
|
|
skillPermissionsSchema,
|
|
} = require('librechat-data-provider');
|
|
const { createRolePermissionsUpdateHandler } = require('@librechat/api');
|
|
const { hasCapability, requireCapability } = require('~/server/middleware/roles/capabilities');
|
|
const { updateRoleByName, getRoleByName, recordAuditEntry } = require('~/models');
|
|
const { requireJwtAuth } = require('~/server/middleware');
|
|
|
|
const router = express.Router();
|
|
router.use(requireJwtAuth);
|
|
const manageRoles = requireCapability(SystemCapabilities.MANAGE_ROLES);
|
|
|
|
/**
|
|
* Permission configuration mapping
|
|
* Maps route paths to their corresponding schemas and permission types
|
|
*/
|
|
const permissionConfigs = {
|
|
prompts: {
|
|
schema: promptPermissionsSchema,
|
|
permissionType: PermissionTypes.PROMPTS,
|
|
errorMessage: 'Invalid prompt permissions.',
|
|
},
|
|
agents: {
|
|
schema: agentPermissionsSchema,
|
|
permissionType: PermissionTypes.AGENTS,
|
|
errorMessage: 'Invalid agent permissions.',
|
|
},
|
|
memories: {
|
|
schema: memoryPermissionsSchema,
|
|
permissionType: PermissionTypes.MEMORIES,
|
|
errorMessage: 'Invalid memory permissions.',
|
|
},
|
|
'people-picker': {
|
|
schema: peoplePickerPermissionsSchema,
|
|
permissionType: PermissionTypes.PEOPLE_PICKER,
|
|
errorMessage: 'Invalid people picker permissions.',
|
|
},
|
|
'mcp-servers': {
|
|
schema: mcpServersPermissionsSchema,
|
|
permissionType: PermissionTypes.MCP_SERVERS,
|
|
errorMessage: 'Invalid MCP servers permissions.',
|
|
},
|
|
marketplace: {
|
|
schema: marketplacePermissionsSchema,
|
|
permissionType: PermissionTypes.MARKETPLACE,
|
|
errorMessage: 'Invalid marketplace permissions.',
|
|
},
|
|
'remote-agents': {
|
|
schema: remoteAgentsPermissionsSchema,
|
|
permissionType: PermissionTypes.REMOTE_AGENTS,
|
|
errorMessage: 'Invalid remote agents permissions.',
|
|
},
|
|
skills: {
|
|
schema: skillPermissionsSchema,
|
|
permissionType: PermissionTypes.SKILLS,
|
|
errorMessage: 'Invalid skill permissions.',
|
|
},
|
|
};
|
|
|
|
/**
|
|
* Generic handler for updating permissions
|
|
* @param {string} permissionKey - The key from permissionConfigs
|
|
* @returns {Function} Express route handler
|
|
*/
|
|
const createPermissionUpdateHandler = (permissionKey) =>
|
|
createRolePermissionsUpdateHandler(
|
|
{
|
|
getRoleByName,
|
|
updateRoleByName,
|
|
recordAuditEntry,
|
|
auditFailClosed: process.env.AUDIT_LOG_FAIL_CLOSED === 'true',
|
|
},
|
|
permissionConfigs[permissionKey],
|
|
);
|
|
|
|
/**
|
|
* GET /api/roles/:roleName
|
|
* Get a specific role by name
|
|
*/
|
|
router.get('/:roleName', async (req, res) => {
|
|
const { roleName } = req.params;
|
|
|
|
try {
|
|
const isOwnRole = req.user?.role === roleName;
|
|
const isDefaultRole = Object.hasOwn(roleDefaults, roleName);
|
|
/** READ_ROLES only gates reading other roles; own role and non-admin default roles skip the probe */
|
|
const requiresReadRoles = !isOwnRole && (roleName === SystemRoles.ADMIN || !isDefaultRole);
|
|
if (requiresReadRoles) {
|
|
let hasReadRoles = false;
|
|
try {
|
|
hasReadRoles = await hasCapability(
|
|
{
|
|
id: req.user?.id ?? req.user?._id?.toString() ?? '',
|
|
role: req.user?.role ?? '',
|
|
tenantId: req.user?.tenantId,
|
|
idOnTheSource: req.user?.idOnTheSource ?? null,
|
|
},
|
|
SystemCapabilities.READ_ROLES,
|
|
);
|
|
} catch (err) {
|
|
logger.warn(`[GET /roles/:roleName] capability check failed: ${err.message}`);
|
|
}
|
|
if (!hasReadRoles) {
|
|
return res.status(403).send({ message: 'Unauthorized' });
|
|
}
|
|
}
|
|
|
|
const role = await getRoleByName(roleName, '-_id -__v');
|
|
if (!role) {
|
|
return res.status(404).send({ message: 'Role not found' });
|
|
}
|
|
|
|
res.status(200).send(role);
|
|
} catch (error) {
|
|
logger.error('[GET /roles/:roleName] Error:', error);
|
|
return res.status(500).send({ message: 'Failed to retrieve role' });
|
|
}
|
|
});
|
|
|
|
/**
|
|
* PUT /api/roles/:roleName/prompts
|
|
* Update prompt permissions for a specific role
|
|
*/
|
|
router.put('/:roleName/prompts', manageRoles, createPermissionUpdateHandler('prompts'));
|
|
|
|
/**
|
|
* PUT /api/roles/:roleName/agents
|
|
* Update agent permissions for a specific role
|
|
*/
|
|
router.put('/:roleName/agents', manageRoles, createPermissionUpdateHandler('agents'));
|
|
|
|
/**
|
|
* PUT /api/roles/:roleName/memories
|
|
* Update memory permissions for a specific role
|
|
*/
|
|
router.put('/:roleName/memories', manageRoles, createPermissionUpdateHandler('memories'));
|
|
|
|
/**
|
|
* PUT /api/roles/:roleName/people-picker
|
|
* Update people picker permissions for a specific role
|
|
*/
|
|
router.put('/:roleName/people-picker', manageRoles, createPermissionUpdateHandler('people-picker'));
|
|
|
|
/**
|
|
* PUT /api/roles/:roleName/mcp-servers
|
|
* Update MCP servers permissions for a specific role
|
|
*/
|
|
router.put('/:roleName/mcp-servers', manageRoles, createPermissionUpdateHandler('mcp-servers'));
|
|
|
|
/**
|
|
* PUT /api/roles/:roleName/marketplace
|
|
* Update marketplace permissions for a specific role
|
|
*/
|
|
router.put('/:roleName/marketplace', manageRoles, createPermissionUpdateHandler('marketplace'));
|
|
|
|
/**
|
|
* PUT /api/roles/:roleName/remote-agents
|
|
* Update remote agents (API) permissions for a specific role
|
|
*/
|
|
router.put('/:roleName/remote-agents', manageRoles, createPermissionUpdateHandler('remote-agents'));
|
|
|
|
/**
|
|
* PUT /api/roles/:roleName/skills
|
|
* Update skill permissions for a specific role
|
|
*/
|
|
router.put('/:roleName/skills', manageRoles, createPermissionUpdateHandler('skills'));
|
|
|
|
module.exports = router;
|