mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-18 14:08:21 +00:00
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
* fix: Remove Group Dependents Before Deleting the Group * feat: Audit Code Worker Pairing and Langfuse Connection Changes * feat: Audit Skill Sync Credential Changes * feat: Audit Passkey Enrolment and Removal * feat: Audit Audit Log Reads and CSV Exports * feat: Audit Audit Log Retention Purges * feat: Audit MCP Server Create, Update and Delete * fix: Keep Purge Result When the Purge Audit Write Fails * test: Cover Admin Integration Audit Scenarios * fix: Tighten Admin Integration Audit Scope and Group Cleanup Order * fix: Run Security Fences Before Awaiting Audit Writes * fix: Move MCP Post-Commit Audit Ordering Into the Auditor and Audit Verify Reads * fix: Fail Closed When Recording Audit Log Access * fix: Audit Group Deletion Before the Cascade and Restore Dependents on Failure * fix: Restore Only Config Overrides When Group Deletion Fails * fix: Audit Worker Pairing and Export Before the Work and Append Failures * fix: Record Group Deletion as Pending Without Delaying Revocation * fix: Skip Config Restore When a Concurrent Delete Removed the Group * fix: Restore Group Config When the Existence Recheck Fails * fix: Keep Group Config Restricted When Delete State Is Unknown * fix: Record Worker Pairing and Revocation as Pending Until Confirmed * fix: Deliver the Pairing Code Before the Terminal Audit Write * test: Assert Pairing Code Delivery Precedes the Terminal Audit Write * fix: Send Revocation and Group Deletion Responses Before the Terminal Audit Write * fix: Snapshot Group Config Before the Destructive Cascade Step * refactor: Type the Group Config Snapshot Dependency Without Mongoose Shapes * fix: Fence Shared MCP Users Before the Deletion Audit and Correlate Audit Attempts * fix: Diff MCP Server Audits Against the Committed Config * fix: Read the Committed MCP Config at Commit Time for the Audit Diff * refactor: Start the Committed MCP Config Read Inside the Auditor * fix: Audit Langfuse Patches When Activation Fails and Surface Failed Group Config Restores * fix: Record Member Removals When Group Deletion Completes After a Failed Restore * test: Serve the Committed Config on the MCP Update Audit Reread * fix: Audit the Group Returned by the Compensating Deletion * fix: Keep Member Removal Audits Fail-Open During Group Deletion * fix: Retry ACL Cleanup After a Compensating Group Deletion * fix: Mark Unavailable Audit Detail and Order Member Removals After the Pending Deletion * fix: Guard Synchronous Committed-Config Read Failures in the MCP Auditor * fix: Return the Persisted MCP Config and Audit Commits That Outlive Cache Invalidation * style: Sort Imports in MCP Audit Files * style: Sort Imports After Restack * fix: Audit MCP Commits That Outlive Any Post-Write Step and Pend Audit Exports Until Complete * test: Provide the Fail-Closed Setting in the Code Route Mock * fix: Refresh MCP Read Caches When a Repository Step Fails After the Write * fix: Finish Audit Exports on Response Completion and Keep Error Details Out of Messages and Logs * fix: Watch Response Completion Before the Truncation Footer Write * fix: Skip Audit for No-op MCP Deletes and Close Remaining Post-Failure Audit Gaps * fix: Keep Causes Out of Structured Logs and Treat a Lost Compensating Delete as Not Found * fix: Mark Failed MCP Post-Commit Steps and Null Langfuse Activation in Audits
120 lines
4.4 KiB
JavaScript
120 lines
4.4 KiB
JavaScript
const express = require('express');
|
|
const request = require('supertest');
|
|
|
|
const mockRequireJwtAuth = jest.fn((req, res, next) => {
|
|
req.user = { id: 'user-1', role: 'ADMIN', tenantId: 'tenant-a' };
|
|
next();
|
|
});
|
|
const mockCapabilityMiddleware = jest.fn((req, res, next) => next());
|
|
const mockRequireCapability = jest.fn(() => mockCapabilityMiddleware);
|
|
const mockHasCapability = jest.fn().mockResolvedValue(true);
|
|
const mockConfigMiddleware = jest.fn((req, res, next) => {
|
|
req.config = { skillSync: { github: { enabled: false, sources: [] } } };
|
|
next();
|
|
});
|
|
const mockGetAppConfig = jest.fn();
|
|
const mockGetGitHubSkillSyncRunnerForRequest = jest.fn();
|
|
const mockHandlers = {
|
|
getSyncStatus: jest.fn((req, res) => res.status(200).json({ ok: true })),
|
|
runSync: jest.fn((req, res) => res.status(200).json({ ok: true })),
|
|
setCredential: jest.fn((req, res) => res.status(200).json({ ok: true })),
|
|
deleteCredential: jest.fn((req, res) => res.status(200).json({ ok: true })),
|
|
};
|
|
const mockSyncAccess = {
|
|
attachBaseSkillSyncConfig: jest.fn((req, res, next) => next()),
|
|
requireReadSkills: jest.fn((req, res, next) => next()),
|
|
attachCredentialReadAccess: jest.fn((req, res, next) => next()),
|
|
requireSyncRunCapability: jest.fn((req, res, next) => next()),
|
|
requirePlatformManageSkills: jest.fn((req, res, next) => next()),
|
|
};
|
|
|
|
jest.mock('@librechat/data-schemas', () => ({
|
|
SystemCapabilities: {
|
|
ACCESS_ADMIN: 'access:admin',
|
|
},
|
|
}));
|
|
|
|
jest.mock('@librechat/api', () => ({
|
|
createAdminSkillsSyncAccess: jest.fn(() => mockSyncAccess),
|
|
createAdminSkillsSyncHandlers: jest.fn(() => mockHandlers),
|
|
}));
|
|
|
|
jest.mock('~/server/middleware/roles/capabilities', () => ({
|
|
hasCapability: mockHasCapability,
|
|
requireCapability: mockRequireCapability,
|
|
}));
|
|
|
|
jest.mock('~/server/middleware', () => ({
|
|
requireJwtAuth: mockRequireJwtAuth,
|
|
}));
|
|
|
|
jest.mock('~/server/middleware/config/app', () => mockConfigMiddleware);
|
|
|
|
jest.mock('~/server/services/Config', () => ({
|
|
getAppConfig: mockGetAppConfig,
|
|
}));
|
|
|
|
jest.mock('~/models', () => ({
|
|
upsertSkillSyncCredential: jest.fn(),
|
|
deleteSkillSyncCredential: jest.fn(),
|
|
recordAuditEntry: jest.fn(),
|
|
}));
|
|
|
|
jest.mock('~/server/services/Skills/sync', () => ({
|
|
getGitHubSkillSyncRunnerForRequest: mockGetGitHubSkillSyncRunnerForRequest,
|
|
}));
|
|
|
|
describe('admin skills sync routes', () => {
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
function createApp() {
|
|
delete require.cache[require.resolve('./skills')];
|
|
const router = require('./skills');
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use('/api/admin/skills', router);
|
|
return app;
|
|
}
|
|
|
|
it('delegates skill sync access policy to the API package', async () => {
|
|
const app = createApp();
|
|
|
|
await request(app).get('/api/admin/skills/sync/status').expect(200);
|
|
|
|
const {
|
|
createAdminSkillsSyncAccess,
|
|
createAdminSkillsSyncHandlers,
|
|
} = require('@librechat/api');
|
|
expect(mockRequireCapability).toHaveBeenCalledWith('access:admin');
|
|
expect(createAdminSkillsSyncAccess).toHaveBeenCalledWith({
|
|
getAppConfig: mockGetAppConfig,
|
|
hasCapability: mockHasCapability,
|
|
});
|
|
expect(createAdminSkillsSyncHandlers).toHaveBeenCalledWith(
|
|
expect.objectContaining({ getRunner: mockGetGitHubSkillSyncRunnerForRequest }),
|
|
);
|
|
expect(mockRequireJwtAuth).toHaveBeenCalled();
|
|
expect(mockCapabilityMiddleware).toHaveBeenCalled();
|
|
expect(mockConfigMiddleware).toHaveBeenCalled();
|
|
expect(mockSyncAccess.attachBaseSkillSyncConfig).toHaveBeenCalled();
|
|
expect(mockSyncAccess.requireReadSkills).toHaveBeenCalled();
|
|
expect(mockSyncAccess.attachCredentialReadAccess).toHaveBeenCalled();
|
|
expect(mockHandlers.getSyncStatus).toHaveBeenCalled();
|
|
});
|
|
|
|
it('mounts package access middlewares before each sync endpoint handler', async () => {
|
|
const app = createApp();
|
|
|
|
await request(app).post('/api/admin/skills/sync/run').expect(200);
|
|
await request(app).put('/api/admin/skills/sync/credentials/default').send({}).expect(200);
|
|
await request(app).delete('/api/admin/skills/sync/credentials/default').expect(200);
|
|
|
|
expect(mockSyncAccess.requireSyncRunCapability).toHaveBeenCalled();
|
|
expect(mockHandlers.runSync).toHaveBeenCalled();
|
|
expect(mockSyncAccess.requirePlatformManageSkills).toHaveBeenCalledTimes(2);
|
|
expect(mockHandlers.setCredential).toHaveBeenCalled();
|
|
expect(mockHandlers.deleteCredential).toHaveBeenCalled();
|
|
});
|
|
});
|