Commit graph

2 commits

Author SHA1 Message Date
Marco Beretta
06065af0f3
🧱 feat: Catch Module-Load Use of Mocked Packages in @librechat/chat (#17539)
* feat: Reject Module-Load Use of Other Packages in the Chat Package

App specs mock whole packages (@librechat/client, librechat-data-provider), so a package module that calls into one or reads a member of one while it loads throws before any test runs. chat/boundary now reports a call, new, tagged template or member read through an external import at module scope in packages/chat/src outside specs; React and Jotai are exempt through a loadSafe option.

* fix: Count Immediately Invoked Functions and Computed Field Keys as Module Load

* fix: See Through Erased TypeScript Wrappers in the Module-Load Check

* fix: Count Destructuring, Spreads and Wrapped IIFEs as Module-Load Reads

* refactor: Judge Every Load-Time Reference to an External Import

The check now walks each external import's references once and reports any that runs on load outside an inert position, instead of listing the node types that read an import. Class heritage, in, instanceof and iteration are reported with no new visitor.

* fix: Follow Branches to Their Consumer and Skip Erased Heritage Types

* fix: Count Constructed Classes and Destructuring Assignments as Module Load

* fix: Count Constructors of Constructed Classes and Branch-Fed IIFEs as Module Load

* fix: Follow Const Aliases of External Imports in the Module-Load Check

* fix: Find Aliases Behind Wrappers and Branches

* fix: Track require Bindings, Skip Writes and Defer Generator Bodies in the Module-Load Check

* fix: Follow Assignment Aliases of External Imports

* fix: Collect require Bindings From Exported Declarations

* refactor: Cover Module-Load Failures With a Mocked-Dependency Load Spec

A packages/chat spec now loads the index, react and components entries with every package the sources import (React and Jotai aside) mocked to a module whose exports are missing, the way an app spec's factory mock leaves it, and asserts nothing throws. That covers aliases, require, invoked functions and the rest at runtime, so chat/boundary keeps only the plain case: a call, new, tagged template or member read through a direct import binding at module scope.

* chore: Retest Against Current Dev

* fix: Exempt Spec Support Files and Node Built-ins From the Module-Load Check
2026-10-29 09:53:59 +01:00
Marco Beretta
8e60a4185a
🧱 refactor: Judge Chat Package Imports on the Resolved Module (#16975)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Votes / vote (full suite) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
Main Promotion Policy Tests / Main promotion denial and fast-forward tests (push) Waiting to run
* refactor: Judge chat imports on the resolved target with one boundary rule

scripts/eslint/chat.mjs replaces the import patterns and load selectors: every
specifier is normalized (extension, trailing slash, /index, package name)
before it is judged, across static imports, re-exports, import(), require(),
import-equals and import types, so any spelling of the /react or /components
entry or a UI package is rejected from core. A RuleTester table and a
table-driven scenario cover the spellings.

* fix: Anchor the chat boundary root to the config directory

* fix: Keep bare app paths and bare core entries behind the chat boundary

* fix: Treat aliased react paths in core as the /react entry
2026-10-11 01:06:07 +02:00