Commit graph

2 commits

Author SHA1 Message Date
Danny Avila
bbd4117928
🧪 test: Release Route Handlers Before Mock Spec Contexts Close (#18064)
A route handler that calls `route.fetch()` can still be running when its test returns. Closing the browser context disposes the fetched response, the handler throws `Response has been disposed`, and Playwright reports that against a test whose assertions had all passed. With `failOnFlakyTests` on, that fails the shard.

Specs that answer requests through `route.fetch()` now take `test` from `e2e/specs/mock/fixtures.ts`. Its `context` fixture detaches the routes on the context and its pages with `unrouteAll({ behavior: 'ignoreErrors' })` before Playwright closes it; contexts a spec opens itself close through `closeContext`.

`ignoreErrors` rather than `wait`: a wait never ends for a handler parked on a promise the test leaves unsettled, and with two handlers in flight Playwright stops intercepting when the first finishes and continues the other request itself, so the second handler's `route.fulfill()` throws `Route is already handled!`.
2026-11-11 16:23:44 -05:00
Marco Beretta
8e9a1722fc
📁 feat: Edit Projects in a Dialog and Pick Files From the Your Files Dialog (#16643)
* feat: Edit Projects in a Dialog and Match the Landing Background

* fix: No Fill on the Edit Project Description Field

* feat: Choose Project Files in the Your Files Dialog

* fix: Filtered Empty State and a Page Retry in the Project File Picker

* test: Scenarios for Project Dialogs and the File Picker

* fix: Retry the Failed Page or the Listed Files, Whichever Failed

* fix: Forget a Picker Page Failure Once the Query Recovers

* fix: Show the Picker Loading While a Further Page Loads

* test: Follow the Picker's Your Files Markup and Its Focus Return

* fix: Apply a Picker Page Result Only to the Query That Requested It

* fix: Hold the Edit Project Dialog Through a Save and Keep Page Failures per Search

* test: Match the Visible Rename Failure Toast

* fix: Refuse to Dismiss Edit Project From the Moment a Save Is Submitted

* fix: Announce the File Grid Result Count to Screen Readers
2026-10-02 23:38:07 +02:00