Commit graph

4 commits

Author SHA1 Message Date
Danny Avila
3b8411d4b5
💬 feat: Show Ask-User Questions Inline in the Chat Instead of Over the Composer (#17839)
* 💬 feat: Show Ask-User Questions Inline in the Chat Instead of Over the Composer

A live ask_user_question pause now starts in its chat card, in thread order and at the thread's width, instead of a popover over the composer that covered most of the screen on phones. The card's chevron still moves a question into the composer popover, and the popover's chevron moves it back.

The shared atom flips from the questions moved to the chat (collapsedAskActionsAtom) to the questions moved to the composer (expandedAskActionsAtom), so the card is the default surface.

* 🔁 fix: Restore Saved Ask Answers in the Inline Card and Focus a Batch Only on Screen

A pending single question's answer is saved under its own draft key, which autosave restores only into the composer. With the chat card as the default surface, a reload showed an empty answer there; the card now reads that saved draft when no in-memory answer exists.

A batch arriving below a reader who has scrolled up took focus on a control out of view. Arrival focus now waits for the step to be on screen (re-measured against the viewport and scroll containers on each IntersectionObserver notification), and still only takes focus when focus is idle. The visibility measurement moves from Thinking.tsx to utils/viewport.ts so both share it.

* 🧷 fix: Keep a Restored Ask Answer When Draft Saving Is Turned Off

The answer restored from a pending question's saved draft lived only in the render-time fallback, so turning Save drafts off while the card was open recomputed it to empty and cleared the visible answer. It is now copied into the in-memory answers once restored, so later preference changes leave it in place, as they do for the composer.

* 🎯 fix: Clear Answered Ask Drafts and Focus the Popover on Handoff

A pending single question's answer is saved under its own draft key. Answered from the composer, autosave cleared it along with the composer; answered from the chat card, which is now the default, nothing cleared it, so every answered question left its text in localStorage. The key is now cleared as soon as the answer is accepted (even after navigating away) and when the question expires, so a saved answer lives exactly as long as its question.

Moving a question from the card into the composer left focus on the card's now-removed button. A single question now focuses the draft, its answer box, and a batch focuses its active step through a new focusOnHandoff prop that is not limited to the first arrival.

* ⌨️ fix: Focus a Single Question on Arrival and Always Focus a Batch Handoff

With the popover gone as the default, a single question arrived with no focus cue: keys typed next in the composer went out as an ordinary mid-run message instead of answering it. The single card now takes arrival focus like a batch does, on its first option or else its answer field, once per question, only once it is on screen and only when focus is idle (nowhere, or the empty composer that sent the turn). Both cards share a new useArrivalFocus hook for the on-screen wait.

A batch moved into the composer popover now takes focus unconditionally: the handoff is the user's own action, and Safari leaves focus on the previous owner of a clicked button, which can be the hidden chat card.

The deferred-tools HITL e2e scenario read its terminal line once as soon as it appeared, while the slow echo was still streaming into it; it now waits for the full text.
2026-11-05 13:46:20 -05:00
Danny Avila
290b8664d9
🧾 feat: Track Authoritative Agent Event Outcomes (#15213)
* feat: track authoritative agent event outcomes

* fix: isolate agent event outcome types

* fix: declare agent event handler result

* fix: simplify agent event status selection

* fix: preserve authoritative event outcomes

* fix: preserve terminal event evidence

* test: use completed run-step envelope

* test: scope deferred HITL question locator

* fix: settle every agent event terminal path

* style: sort terminal host action imports

* fix: fence agent event terminal evidence

* fix: recover agent event terminal settlement

* fix: scope terminal retry hints by generation

* fix: settle terminal host actions exactly
2026-08-25 18:20:57 -04:00
Danny Avila
7347cfc195
🍡 feat: Batched User Questions With A Single Bounded Answer Form (#14737)
* feat: support batched user questions

* test: align batched question fixtures

* fix: harden batched question lifecycle

* test: submit batched HITL answers in e2e

* fix: address batched question review findings

* fix: preserve invoke return typing
2026-08-11 01:06:16 -04:00
Danny Avila
60ca751a7f
🧠 fix: Preserve Deferred Tool Schemas Across HITL Resume (#14552)
Some checks are pending
Docker Dev Branch Images Build / build (Dockerfile, lc-dev, node) (push) Waiting to run
Docker Dev Branch Images Build / build (Dockerfile.multi, lc-dev-api, api-build) (push) Waiting to run
GitNexus Index / index (push) Waiting to run
GitNexus Index / post-index (push) Blocked by required conditions
* 🧠 fix: Preserve deferred tool schemas across HITL resume

* 🧪 test: Harden deferred tool resume regression

* 📦 chore: bump @librechat/agents to v3.3.10
2026-07-31 14:06:13 -04:00