Commit graph

9 commits

Author SHA1 Message Date
Danny Avila
502a5734be
🧪 test: Close Two Timing Gaps That Untraced Mock E2E Attempts Expose (#18086)
* 🧪 test: Measure Activity Fold Labels Once the Header Slide Lands

Opening a fold slides its header's new label in over the old one (300 ms).
The clean-phase test read the phase label's box right after opening the
group below it, still inside that slide, then compared it with the box after
a rail hover; the two differ by a fraction of a pixel. A traced attempt is
slow enough that the slide has landed first. Wait for the header's finite
animations to finish before taking the reference box.

* 🧪 test: Find the Mention Endpoint Row in the Mention List Alone

The drill-down test looked up `Mock Provider C` as any option on the page.
The setup picks Mock Provider A from the model menu just before, and that
menu keeps its options in the accessibility tree for about 100-160 ms while
it fades out, Mock Provider C among them, so an untraced attempt that types
the filter in that window hits a strict-mode violation. Look the row up in
the listbox the mention combobox controls.
2026-11-12 09:47:37 -05:00
Marco Beretta
0491d60ae6
🧹 fix: Simplify Tool Activity Headers (#17512)
Some checks failed
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Vote Gate / Gate (push) Waiting to run
Codegraph E2E Votes / vote (shard 1/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 10/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 2/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 3/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 4/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 5/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 6/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 7/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 8/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 9/10) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Has been cancelled
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Has been cancelled
* fix: Simplify Tool Activity Headers

* fix: Preserve Interactive Flattened Tool Results

* test: Update Fold Tree Scenarios for Hidden Markers

* fix: Restore Tool Activity Tree Markers

* fix: Smooth Streaming Tool Disclosures and Show Command Timers

* fix: Align Tool UI Imports With Shared Chat Components

* fix: Hide Durations on File Read and Authoring Cards

* fix: Phrase Tool Durations as Part of the Label

* style: Match Thoughts Panel Radius to Tool Panels

* fix: Keep the Bash Copy Button Clear of the Command

* style: Space Thoughts Rows Like Tool Rows

* style: Render Agent Handoff as a Tool Disclosure

* style: Even Padding on the File Search Relevance Badge

* feat: Show Loaded Skill Instructions With an Open Skill Action

* style: Align Memory Panel Typography With Tool Panels

* style: Show Full File Paths and Match the Diff to Code Panels

* style: Pin Tool Durations and Chevrons to the Row End

* style: Use an Icon Button to Open a Loaded Skill

* style: Always Show Disclosure Chevrons

* style: Compact, Evenly Inset Copy Buttons in Tool Panels

* fix: Draw No Fold Rail Around a Lone Tool Call

* fix: Put a Titled Command's Time on Its Command Line

* fix: Hide a Bare File Edit Summary

* style: Compact Copy Button on Thoughts Headers

* fix: Move Titled Web Search Details Into the Sources Panel Header

* fix: Show Titled Web Search Details Beside the Title Chevron

* fix: Import Tool Call Phase Types From the Chat Package

* test: Cover Tool Activity Header Scenarios

* fix: Read Smooth Streaming Through the Message Parts Host

* fix: Keep a Command's Measured Time When Its Title Takes Over

* fix: Show a Loaded Skill Only When Its Name Is Unambiguous

* fix: Keep Nested Group Rails and the Handoff Label Text

* fix: Keep Skill Execution Warnings Beside Its Instructions

* fix: Label Loaded Skill Instructions as the Current Version
2026-11-03 23:56:02 +01:00
Marco Beretta
229303c669
🌿 feat: Branch Tool Fold Rails Into Each Row (#17407)
* feat: Branch Tool Fold Rails Into Each Row

Draw each open fold's rail as a trunk with a curved branch into every
row, measured from the rows themselves. Hovering a row lights the route
along the tree: out of the previous branch, along the trunk and into the
new one, at a steady pace. Layout changes under a still pointer (folding,
streaming, scrolling) re-hit-test instead of clearing the path.

* fix: Retrace the Fold Path When Its Row Moves Mid-Trip

A row that moved while the lit path was still traveling to it kept the
trip measured to its old position, so the path ran the old distance and
jumped the rest. Start a fresh trip from the path's current position
whenever the destination row moves.

* test: Cover the Tool Fold Tree With Scenario Specs

One tagged Playwright scenario per contract behavior: branches into each
row, the hover route from the header, nested folds, travel along the
tree, a click that unfolds the hovered row, reduced motion, right-to-left
mirroring and touch.
2026-10-24 13:56:07 +02:00
Marco Beretta
fd85fed204
💬 fix: Mirror Chat Messages, Markdown and Code Blocks for RTL (#17267)
* fix: Mirror Chat Surfaces For RTL Layouts

* fix: Keep Short Subagent Ticker Lines at Their Reading Start

Adds RTL chat scenarios covering code, markdown blocks, sibling arrows and virtualized lists.

* fix: Resolve Quote and List Direction From Their Content

dir=auto skips descendants that carry their own dir, so a quote or loose list holding dir=auto paragraphs always resolved left-to-right. Lists now take one direction so markers and indent stay on the same side.

* fix: Keep Tables, Callouts and Trace Axes on One Direction

Tables take one direction from their content so cell borders share a frame; strong-direction detection skips Arabic-Indic digits, separators and marks; handoff and answer callouts use a logical start border; trace tick and range labels stay on the LTR axis.

* fix: Treat Every Script's Letters as Strong Direction

Direction detection now keys on Unicode letters, so Devanagari, Thai and other LTR scripts resolve LTR. E2E specs that selected rows by pl-6 now select ps-6.

* test: Cover the Shared Strong Direction Helper on Its Own

* fix: Read Bidi Marks and Native Script Digits as Strong Direction

* fix: Approximate Bidi Classes by Block So Symbols and Numerals Resolve

* fix: Resolve Strong Direction From Unicode Bidi Class Tables

* docs: Note How the Bidi Tables Are Generated and Where They Differ

* fix: Generate the Bidi Tables From Unicode 17 Including L-Class Marks
2026-10-20 16:19:14 +02:00
Danny Avila
3dd0d06796
🧗 feat: Light the Fold Path to the Hovered Activity Row (#16722)
* 🪜 feat: Light the Fold Path to the Hovered Activity Row

- Every fold that holds the hovered row lights its rail from its header down to that row; the innermost turns into the row with an elbow, so depth reads as the number of lit rails.
- One pointer listener on the outermost fold writes the path onto the rails directly (a data attribute and a length variable), coalesced to one frame: hovering repaints rails, never rows.
- Rows are found by the shared glyph slot every row line starts with, so no row component marks itself.
- The path clears over a rail (which shows its own collapse hover), on touch, on a press and when the pointer leaves.

* fix: Invalidate Fold Hover Paths and Reuse Glyph Lists

* fix: Scope Fold Paths to Agent Lanes and Register Subagent Glyphs

* fix: Re-Hit-Test Queued Fold Paths After Scroll

* fix: Clear Fold Paths After Ancestor Layout Shifts

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-10-04 09:16:52 -04:00
Danny Avila
e689243d9d
🪢 feat: Collapse Activity Folds From Their Rails (#16637)
* 🪢 feat: Collapse Activity Folds From Their Rails

Hovering an open fold's rail lights the line and swaps the header's glyph for a collapse knob; clicking the rail collapses that fold and brings its header back into view.

* fix: Stabilize Fold Rail Hover and Header Reveal

* fix: Reserve the Chat Toolbar When Revealing Folds

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-10-01 19:58:38 -04:00
Lia
596c4dd592 🛶 fix: Keep Revealed Queue Actions and E2E Flows After Composer Redesign
(cherry picked from commit 25d74a636d)

Original-PR: https://github.com/LibreChat-AI/LibreChat/pull/16361
2026-10-01 03:46:18 +00:00
Danny Avila
63363a7776
⏱️ fix: Fit Workspace Command Timeouts Inside the Configured Request Budget (#16464)
Some checks are pending
Docker Dev Images Build / publish (push) Waiting to run
Sync Helm Chart Tags / Ignore non-main push (push) Waiting to run
Sync Helm Chart Tags / Sync chart tags (push) Waiting to run
* ⏱️ fix: Fit Workspace Command Timeouts Inside the Configured Request Budget

* ⏱️ fix: Make Workspace Command Admission Reserve Configurable

* 🧪 test: Match Steering E2E Labels on Dev

* ⏱️ fix: Reject Impossible Workspace Command Admission Reserves

* 🧪 test: Match Failed Call Count in Dev E2E

* ⏱️ fix: Bound Workspace Admission Headroom and Document Its Budget

* ⏱️ fix: Validate Default Workspace Command Admission Reserve

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-09-28 22:53:14 -04:00
Danny Avila
a047548fa7
🪜 feat: Title an Open Activity Fold and Reach Failed Calls in One Click (#16390)
* 🪜 feat: Title an Open Activity Fold and Reach Failed Calls in One Click

An open phase or tool group now reads as the title of the rows under it:
the header steps up to primary semibold, pins the stable label instead of
the live line, and sticks to the top while its rows scroll. Rows step in
24px under a hairline rail hung from the header glyph, one level per fold.

A failure is one click away from anywhere. A "N failed" pill beside the
header opens the fold and every failed row's output; a collapsed card peeks
its first failed call and error line under the header; the failed row
carries a red stripe, the error's first line as its subtitle, and names its
subject by the model's intent as the live header and peek already do.

The reveal travels down a FailedRevealContext counter that a group relays to
its own rows only once they have mounted, so a request made on a closed
card reaches a row three lazy disclosures below it.

* 🧪 test: Drive the Activity Fold Through the Real App and Fix What It Showed

A mock-lane spec runs a phase whose middle batch holds a call that failed
schema validation beside a slow one, watches the fold stream, then reaches
the error from the peek, from the pill, and again after a reload, in both
themes, with no console or page errors.

Three things the real app showed that the harness had not:

- The client counted only two of the server's three failed-output shapes,
  so a schema-validation failure that the server labelled `partial` rendered
  as a completed card with no pill. `isError` now mirrors
  `completedToolExecutionStatus`.
- A row's label lost its last letters to an ellipsis whenever its subtitle
  overflowed: the weighted shrink left the label a fraction of a pixel short.
  The subtitle now takes all of the shrink and the label caps at the row.
- The peek named an MCP call by its server while the row named the tool.
  Both now name it the way the row does, and the error line drops its bare
  `Error:` prefix the red glyph already speaks for.

* 🎯 fix: Answer a Failed-Call Reveal From Every Card's Disclosure Control

The reveal was consumed by the generic ToolCall row alone, so a failed
bash, code, memory, file or skill card, each rendered through its own
component, opened its group and stopped. The consumer now lives in
ProgressText, the disclosure control every card renders: a failed, openable,
closed row opens through the card's own toggle, and the one row the request
lets take focus lands the reader on its labeled button rather than on an
unnamed wrapper. The request carries a one-shot focus claim, relayed
through nested providers, so a phase with several failures opens all of
them and focuses only the first in document order, the one its peek named.

Also from the same review: an error line is derived only from output that
is an error, so a step failed by its run status or a status attachment no
longer shows ordinary output in red; a standalone group shows its failure
count once, on the pill, keeping the text for the accessible name; and the
label and subtitle share one shrinking box so the verdict, duration and
chevron after them never lose width.

* 🎯 fix: Make Failed Activity Cards Reachable From Fold Controls

* 🛡️ fix: Keep Legacy Search Errors Hidden Outside Failure Summaries

---------

Co-authored-by: Lia <lia@librechat.ai>
2026-09-26 21:25:30 -04:00