mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-18 14:08:21 +00:00
3 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
03eb7be12e
|
🛡️ fix: Keep Azure Keys Off Unserved Groups, Let Hides Take Their Specs, and Report Inert Azure Groups (#17411)
Some checks are pending
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Codegraph E2E Vote Gate / Gate (push) Waiting to run
Codegraph E2E Votes / vote (shard 1/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 10/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 2/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 3/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 4/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 5/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 6/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 7/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 8/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 9/10) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
- A group a layer names that the config below does not serve (one a lower layer's tombstone of a field inside it, or of its groupMap entry, left unable to resolve) gets no key from the YAML-shaped group: a higher layer that re-supplies the field and a new instance or base URL no longer sends librechat.yaml's key there. - /changes and PATCH report unknown_spec_endpoint only where the write touches the spec, so hiding, removing or unsetting the endpoint a profile's stored spec selects is no longer refused; the merge leaves the spec out, as the single-field routes already allowed. - Without CONFIG_REDERIVE_ENDPOINTS, a layer's Azure groups and its tombstones of them (whole, keyed or inside a group) are listed as endpoint_rederive_off in each resolution layer, in GET ignored and in the /changes report. With it, a keyed tombstone that leaves its group unable to resolve is listed as azure_groups_unresolved. Keyed tombstones are located by entry key. - The startup report lists documents whose only Azure override is a keyed group tombstone. - Docs: hides never refused for the specs they take, the new ignored reasons. |
||
|
|
9f617fc4ad
|
🧬 feat: Re-Derive Azure Groups, Vertex AI, Custom Parameters and Spec Defaults for Config Profiles (#17399)
* 🧬 feat: Re-Derive Azure Groups, Vertex AI, Custom Parameters and Spec Defaults for Config Profiles AppService derives part of the served config from librechat.yaml at startup, and config profiles merged into that output without deriving it again. Azure `groups` now merge by `group` like `endpoints.custom` by `name`: a profile's partial group merges over the group of that name, groups it does not name stay, indexed writes are refused, change batches take entry ops on them, and groups that do not resolve over librechat.yaml and Base (or whose written `${VAR}` is not set) answer `invalid_azure_groups`. Each merged group keeps the key below it unless the profile supplies one, so the rebinding guard drops a key a partial item moves and a key a lower layer dropped stays dropped; Azure re-entry compares groups merged the same way. With `CONFIG_REDERIVE_ENDPOINTS=true` (opt-in for this release), a profile's Azure `groups` resolve into what the Azure clients read (unconditional before, now behind the switch so stored group overrides do not go live on upgrade), a profile's `endpoints.anthropic.vertex` derives `vertexConfig` and the Anthropic models it serves where librechat.yaml configures Vertex AI, and the Azure Assistants endpoint follows a profile's `assistants`. Startup logs the documents that hold such overrides, the groups that would not resolve over librechat.yaml and Base, and the Vertex AI overrides that never apply. Always on: Vertex AI's key file and region are base-only, a profile may turn Vertex AI on only where librechat.yaml configures it, its settings may reference only librechat.yaml's own Vertex AI variables (reads return them resolved), a profile's `vertexConfig` is never applied and writes skip it (`derived_path`, `rules.derivedPaths`), a model's own `deploymentName` resolves its `${VAR}` like the default one, the region, project ID and the deployment name each model's requests send (the model name where the client sends it as written) must stay in their URL host label or path segment, a `${VAR}` there is a whole `${NAME}` reference only, the Anthropic client refuses any other deployment name before building a request, and an invalid setup answers `invalid_vertex_config`. The rebinding guard no longer binds the derived Vertex AI region, which is librechat.yaml's. Custom endpoint `customParams` are expanded by `expandCustomEndpoint` into the served copy, so `appConfig.config` stays librechat.yaml as written, and each endpoint a profile writes is expanded again from its merged form (a changed `defaultParamsEndpoint`, OpenRouter defaults for a profile's own endpoint); invalid definitions answer `invalid_param_definitions`. After tenant scoping, `getAppConfig` derives `modelSelect`, `parameters` and `presets` again for the specs a principal is served where nothing sets them, the agents `memory` capability follows the merged memory config, and a model spec naming an unconfigured endpoint answers `unknown_spec_endpoint`. Meta flags: `azureGroupMergeKey`, `customParamsExpansion`, `specInterfaceRederive` and `endpointRederive`. * 🪜 fix: Judge Re-Derived Config on What Every Profile Layer Leaves Two re-derivations decided whether a profile had set a field from whether any layer ever set it, so a lower profile's value tombstoned by a higher one still counted as set. - Vertex AI (CONFIG_REDERIVE_ENDPOINTS=true): the marker that keeps a profile's `endpoints.anthropic.models` over Vertex AI's is cleared by a later tombstone of those models (or of `endpoints.anthropic` or `endpoints`), and such a tombstone derives Vertex AI again, so the Anthropic endpoint serves Vertex AI's models instead of none. A tombstone of librechat.yaml's own models does the same. - Spec-dependent controls: `modelSelect`, `parameters` and `presets` are derived again where their served value differs from the base config's, not only where the librechat.yaml-shaped value does, so a control one profile sets and a higher one tombstones, or a tombstone of one librechat.yaml leaves unset, follows the specs served instead of being dropped. The memory capability, Azure Assistants, Azure groups and custom parameters already derive from the merged result; tests now cover each set in one layer and tombstoned in a higher one, and the reverse. * 🧮 fix: Derive Each Config Part From What the Layers Leave A tombstone of an object above a derived part's inputs, alone or followed by a layer that recreates part of that object, left the part without what startup derives it to: - An Azure endpoint recreated after a tombstone of `endpoints.azureOpenAI` or `endpoints` had no groupMap, modelGroupMap or model lists, so its model lists fell back to the environment's default Azure models, which requests could not map to a group. It now serves no group, with or without CONFIG_REDERIVE_ENDPOINTS (completeAzureResolution). - A tombstone of the whole `interface` left modelSelect, parameters and presets out, which the client reads as off. They are derived from the specs served into a new interface. - A tombstone of `endpoints.agents` or `endpoints` left no agents endpoint, while a tombstone of its capabilities served the defaults. The agents endpoint startup derives is served there. - A tombstone of a Vertex AI setting that leaves the setup unable to load kept the vertexConfig derived below it. Vertex AI is off there, with a warning. A table in service.spec.ts runs every derived part against every way a layer changes its inputs (set, unset, a tombstone of the path and of each object above it, a layer recreating after such a tombstone, Base on either side, tenant scoping, the switch off) through getAppConfig, and compares each cell with what startup derives from the librechat.yaml the layers leave. * 🧭 fix: Serve Only Model Specs Whose Endpoint the Layers Leave A tombstone of `endpoints.custom` or `endpoints` in a higher profile (or the Base profile) left the model specs of the custom endpoints it removes served, librechat.yaml's or a lower profile's: the spec list pointed at endpoints /api/endpoints no longer offers, with the model selector, parameters and presets still off for them. The write check only ran when the write held `modelSpecs.list`, and the merge served stored specs as they were. After the last layer, the merge now serves only the specs whose endpoint is a built-in endpoint or a custom endpoint the YAML-shaped config the layers leave defines, the rule startup skips librechat.yaml's specs by (deriveServedSpecs). A removed endpoint hides its specs until a layer defines it again; where no spec is left, none is served (as with a tenant-hidden endpoint) and the spec-dependent controls come back on. Tombstones of a built-in endpoint's settings keep its specs, as startup does, and `addedEndpoints` stays as merged. A stored spec for an endpoint that is not configured is left out on its own instead of being served; writes of one still answer 400 unknown_spec_endpoint. The derived-part table in service.spec.ts gains the model specs served (with addedEndpoints and the controls they decide) against tombstones of `endpoints.custom`, `endpoints`, and each of `endpoints.openAI`, `azureOpenAI` and `anthropic`: by a profile, by Base under a profile, a lower profile under a higher one, recreated above or by the same layer, with no spec left, and with the switch off. * 🧩 fix: Reconcile Re-Derived Config With Dev's Keyed Tombstones, Write Report and Read APIs - Keyed tombstones of Azure groups (endpoints.azureOpenAI.groups["g"], now merged by key) resolve the groups left again where the merge resolves them, and stay inert without CONFIG_REDERIVE_ENDPOINTS. - Keyed tombstones count as touching endpoints.custom, so served specs and custom parameters are derived again after one. - The served-spec derivation keeps modelSpecs while added endpoints remain, as the hidden endpoint scoping does; hidden endpoint names leave addedEndpoints. - Derived paths join the held paths every write skips, built on first use. - Tests follow the merged behaviour: Azure groups merge by group, the agents endpoint is derived again below a tombstone. |
||
|
|
0716094734
|
🏷️ feat: Hide and Rename Custom Endpoints by Name in Config Profiles (#17396)
* 🏷️ feat: Hide and Rename Custom Endpoints by Name in Config Profiles Config profiles merge `endpoints.custom` over librechat.yaml entry by entry on `name`, but could not take one entry away. A tombstone that named one, such as `endpoints.custom["Name"]`, passed every check, was stored with a 200 and did nothing, because the merge removes object paths only and stops at arrays; a tombstone at a position (`endpoints.custom.0.headers`) was stored and did nothing either. Renaming a profile's own endpoint through PUT or PATCH lost its stored key, since the `renames` hint covered MCP servers only. POST `/fields/tombstone`, DELETE `/fields` and the `tombstone` and `unset` ops of a change batch now take a keyed path, `endpoints.custom["<name>"]` or `endpoints.custom["<name>"].<path>`, whose name is a JSON string compared as the merge folds it. A tombstone hides the inherited endpoint, or one of its fields or record keys, for the profile's principals and removes the profile's own entry or path; hiding an endpoint also hides the model specs that select it, whether librechat.yaml or a lower profile defines it. An unset resets the profile's own entry or path with the keyed tombstones at or below it, and writing an entry clears the tombstone that hides it whole. Malformed keyed paths, keyed paths after arrays not merged by key, the entry's name, its key, preview or destination fingerprint, keyed writes and positional tombstones answer 400, and the store's keyed mutations refuse a location whose stored tombstone would name another path. A `segments` target names keys as written on every route, so a segment such as `custom["Name"]` never reaches an entry past these guards: a write by it stores a key of that spelling and clears none of the entry's tombstones. A stored tombstone reads as keyed only after an array merged by key, so an older one such as `mcpServers.a["b"]` keeps hiding that server. PUT and PATCH `renames` also take `{ path: 'endpoints.custom', previousName, name }`: the renamed entry gets the stored ciphertext and preview, and the keyed tombstones of the old name move to the new one, as they do for a batch `rename`. The carried key stays bound to its destination (400 `CONFIG_SECRET_REENTRY_REQUIRED` when the renamed entry sends it elsewhere) and keeps the destination fingerprint it was entered with; a hint that cannot apply answers 400 `CONFIG_RENAME_INVALID` with a reason. Removing the destination of a profile's own keyed entry beside its stored key needs the key again, and removing an inherited one drops the inherited key at merge and lists it in `ignored`. The merge-key registry moves to its own module so mutations can match entries by identity without an import cycle. Meta reports `keyedTombstones` and `renameHints`, `rules.renameHintPaths` and `limits.maxEntryKeyLength`, and `docs/endpoint-overrides.md` documents the contract. * 🙈 fix: Scope Hidden Endpoint Allow-Lists and Refuse Duplicate Rename Sources - A hidden custom endpoint leaves endpoints.agents.allowedProviders as it leaves modelSpecs; scopeHiddenEndpointSpecs becomes scopeHiddenEndpointReferences. - modelSpecs collapses only when no spec and no added endpoint remain, so unrelated addedEndpoints survive when the hidden endpoint owned every spec (tenant scoping shares the helper). - An addedEndpoints or allowedProviders list that names only hidden endpoints is kept whole: an empty list allows every endpoint. - Two endpoints.custom rename hints from one previousName answer CONFIG_RENAME_INVALID duplicate_source; MCP hints may still duplicate a server. * 🔀 fix: Keep Keyed Tombstones Whole Across Dev's Patch Steps, Write Report and Resolved API - PATCH resets (dev's request-ordered steps) still move a renamed entry's keyed tombstones, in validation and in the stored state; lifted tombstones come from one data-schemas helper for both paths. - The write report of POST /fields/tombstone and DELETE /fields names a keyed location by its keyed path, collection, key and entryPath, as a change ref does, instead of the bare collection. - resolveConfigLayers scopes the model specs and allow-lists of hidden endpoints as getAppConfig does, so the resolved API keeps its parity. - GET /meta reports maxEntryKeyLength beside dev's catalogModelsTtlMs. |