Commit graph

1 commit

Author SHA1 Message Date
Danny Avila
64f2124cc6
🔐 fix: Keep the Admin OpenID State So PKCE Holds When the IdP Omits S256 (#17478)
openid-client's Passport Strategy replaces the authorization request's state with a random one
when the IdP's discovery metadata does not list S256 in code_challenge_methods_supported and the
request has no nonce. Azure Entra ID omits that field, so the admin callback could not find the
admin panel's PKCE challenge under pkce:<state> and issued an exchange code that any
code_verifier, or none, could redeem.

The admin strategy now adds a nonce in that case, so openid-client keeps the admin route's state
and checks the nonce against the ID token on the callback. The chat OpenID flow is unchanged.
2026-10-28 18:33:12 +01:00