From 01448c09745e5536942308b5655241d4e46dce89 Mon Sep 17 00:00:00 2001 From: marbence101 Date: Mon, 12 Oct 2026 13:43:22 +0200 Subject: [PATCH] fix: resolve earlier-turn checkpoint sources when resuming a temporary chat --- .../api/src/agents/hitl/protection.spec.ts | 41 +++++++++++++++++++ packages/api/src/agents/hitl/protection.ts | 4 +- 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/packages/api/src/agents/hitl/protection.spec.ts b/packages/api/src/agents/hitl/protection.spec.ts index 86f0220a26..f9bd786cc8 100644 --- a/packages/api/src/agents/hitl/protection.spec.ts +++ b/packages/api/src/agents/hitl/protection.spec.ts @@ -350,6 +350,47 @@ describe('assertResumeRuntimeContentAllowed', () => { ); }); + it('resolves earlier-turn checkpoint sources in a temporary chat', async () => { + const dependencies = createDependencies(); + dependencies.getAgentCheckpointer.mockResolvedValue({ + getTuple: jest.fn().mockResolvedValue({ + checkpoint: { + channel_values: { + messages: [ + { + role: 'human', + additional_kwargs: { sourceMessageId: 'earlier-turn' }, + }, + { + role: 'human', + additional_kwargs: { sourceMessageId: 'paused-turn' }, + }, + ], + }, + }, + }), + }); + dependencies.getMessages.mockResolvedValue([ + { messageId: 'earlier-turn', isCreatedByUser: true, role: 'user', text: 'hi' }, + { messageId: 'paused-turn', isCreatedByUser: true, role: 'user', text: 'ask me' }, + ]); + const input = { + ...createInput({}), + isTemporary: true, + storedMessages: [{ messageId: 'paused-turn', isCreatedByUser: true, role: 'user' }], + }; + + await expect(assertResumeRuntimeContentAllowed(input, dependencies)).resolves.toEqual({ + resolvedFiles: [], + checkpointFiles: [], + }); + expect(dependencies.getMessages).toHaveBeenCalledWith({ + conversationId: 'conversation-1', + user: 'user-1', + }); + expect(dependencies.getFiles).not.toHaveBeenCalled(); + }); + it('preserves repeated steer file injections in checkpoint projection', async () => { const dependencies = createDependencies(); dependencies.getAgentCheckpointer.mockResolvedValue({ diff --git a/packages/api/src/agents/hitl/protection.ts b/packages/api/src/agents/hitl/protection.ts index 88d2720034..f3bb837cea 100644 --- a/packages/api/src/agents/hitl/protection.ts +++ b/packages/api/src/agents/hitl/protection.ts @@ -1047,9 +1047,11 @@ export async function assertResumeRuntimeContentAllowed( const missingSourceMessageIds = [...checkpointSourceMessageIds].filter( (messageId) => !resolvedSourceMessageIds.has(messageId), ); + /** The preflight only carries the paused turn; earlier turns referenced by the + * checkpoint are read back for temporary chats too, whose messages stay + * persisted until `expiredAt`. */ if ( modelBoundProjection?.historyLoaded !== true && - !input.isTemporary && missingSourceMessageIds.length > 0 && input.user?.id ) {